More sane defaults for helpers

Also make sure errors while scrolling will not be ignored
Fixes #194
This commit is contained in:
Honza Král
2015-02-18 18:28:55 +01:00
parent 7dbf753ef5
commit 79ca075ab0
3 changed files with 37 additions and 12 deletions
@@ -134,7 +134,8 @@ class TestBulk(ElasticsearchTestCase):
self.client,
[{"a": 42}, {"a": "c", '_id': 42}],
index="i",
doc_type="t"
doc_type="t",
raise_on_error=False
)
self.assertEquals(1, success)
self.assertEquals(1, len(failed))
@@ -144,7 +145,7 @@ class TestBulk(ElasticsearchTestCase):
self.assertEquals('i', error['index']['_index'])
self.assertIn('MapperParsingException', error['index']['error'])
def test_error_is_raised_if_requested(self):
def test_error_is_raised(self):
self.client.indices.create("i",
{
"mappings": {"t": {"properties": {"a": {"type": "integer"}}}},
@@ -156,8 +157,7 @@ class TestBulk(ElasticsearchTestCase):
self.client,
[{"a": 42}, {"a": "c"}],
index="i",
doc_type="t",
raise_on_error=True
doc_type="t"
)
def test_errors_are_collected_properly(self):
@@ -173,7 +173,8 @@ class TestBulk(ElasticsearchTestCase):
[{"a": 42}, {"a": "c"}],
index="i",
doc_type="t",
stats_only=True
stats_only=True,
raise_on_error=False
)
self.assertEquals(1, success)
self.assertEquals(1, failed)