eric sciple
656a821a94
Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
102 lines
2.4 KiB
TypeScript
102 lines
2.4 KiB
TypeScript
import {actionIdentifier, parseActionReference as parse} from "./action.js";
|
|
|
|
describe("parseActionReference", () => {
|
|
it("basic action", () => {
|
|
expect(parse("actions/checkout@v2")).toEqual({
|
|
owner: "actions",
|
|
name: "checkout",
|
|
ref: "v2"
|
|
});
|
|
});
|
|
|
|
it("action with reference to branch", () => {
|
|
expect(parse("actions/checkout@main")).toEqual({
|
|
owner: "actions",
|
|
name: "checkout",
|
|
ref: "main"
|
|
});
|
|
});
|
|
|
|
it("action with reference to branch with slashes", () => {
|
|
expect(parse("actions/checkout@features/a")).toEqual({
|
|
owner: "actions",
|
|
name: "checkout",
|
|
ref: "features/a"
|
|
});
|
|
});
|
|
|
|
it("action with reference to commit sha", () => {
|
|
expect(parse("actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b")).toEqual({
|
|
owner: "actions",
|
|
name: "checkout",
|
|
ref: "755da8c3cf115ac066823e79a1e1788f8940201b"
|
|
});
|
|
});
|
|
|
|
it("valid action with path", () => {
|
|
expect(parse("actions/checkout/path/to/action@v2")).toEqual({
|
|
owner: "actions",
|
|
name: "checkout",
|
|
ref: "v2",
|
|
path: "path/to/action"
|
|
});
|
|
});
|
|
|
|
it("valid action with path and trailing slash", () => {
|
|
expect(parse("actions/checkout/path/to/action/@v2")).toEqual({
|
|
owner: "actions",
|
|
name: "checkout",
|
|
ref: "v2",
|
|
path: "path/to/action"
|
|
});
|
|
});
|
|
|
|
it("local action", () => {
|
|
expect(parse("./")).toBeUndefined();
|
|
});
|
|
|
|
it("local action with path", () => {
|
|
expect(parse("./directory/")).toBeUndefined();
|
|
});
|
|
|
|
it("Docker Hub action", () => {
|
|
expect(parse("docker://alpine:3.8")).toBeUndefined();
|
|
});
|
|
|
|
it("GitHub Packages Container action", () => {
|
|
expect(parse("docker://ghcr.io/OWNER/IMAGE_NAME")).toBeUndefined();
|
|
});
|
|
|
|
it("action with backslashes", () => {
|
|
expect(parse("actions\\checkout\\path\\to\\action@v2")).toEqual({
|
|
owner: "actions",
|
|
name: "checkout",
|
|
ref: "v2",
|
|
path: "path/to/action"
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("actionIdentifier", () => {
|
|
it("basic action", () => {
|
|
expect(
|
|
actionIdentifier({
|
|
owner: "actions",
|
|
name: "checkout",
|
|
ref: "v2"
|
|
})
|
|
).toEqual("actions/checkout/v2");
|
|
});
|
|
|
|
it("action with path", () => {
|
|
expect(
|
|
actionIdentifier({
|
|
owner: "actions",
|
|
name: "checkout",
|
|
ref: "v2",
|
|
path: "path/to/action"
|
|
})
|
|
).toEqual("actions/checkout/v2/path/to/action");
|
|
});
|
|
});
|