Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
133 lines
3.2 KiB
TypeScript
133 lines
3.2 KiB
TypeScript
import {documentLinks} from "./document-links.js";
|
|
import {createDocument} from "./test-utils/document.js";
|
|
import {clearCache} from "./utils/workflow-cache.js";
|
|
|
|
beforeEach(() => {
|
|
clearCache();
|
|
});
|
|
|
|
describe("documentLinks", () => {
|
|
it("no links without actions", async () => {
|
|
const input = `on: push
|
|
jobs:
|
|
build:
|
|
runs-on: [self-hosted]
|
|
steps:
|
|
- run: echo "Hello World"`;
|
|
const result = await documentLinks(createDocument("test.yaml", input), undefined);
|
|
expect(result).toHaveLength(0);
|
|
});
|
|
|
|
it("no links for invalid workflow", async () => {
|
|
const input = `onFOO: push
|
|
jobs:
|
|
build:
|
|
runs-on: [self-hosted]`;
|
|
const result = await documentLinks(createDocument("test.yaml", input), undefined);
|
|
expect(result).toHaveLength(0);
|
|
});
|
|
|
|
it("links for actions in workflow", async () => {
|
|
const input = `on: push
|
|
jobs:
|
|
build:
|
|
runs-on: [self-hosted]
|
|
steps:
|
|
- uses: actions/checkout@v2
|
|
- uses: actions/checkout@v3
|
|
- uses: github/codeql-action/init@v2`;
|
|
const result = await documentLinks(createDocument("test.yaml", input), undefined);
|
|
expect(result).toEqual([
|
|
{
|
|
range: {
|
|
end: {
|
|
character: 31,
|
|
line: 5
|
|
},
|
|
start: {
|
|
character: 12,
|
|
line: 5
|
|
}
|
|
},
|
|
target: "https://www.github.com/actions/checkout/tree/v2/",
|
|
tooltip: "Open action on GitHub"
|
|
},
|
|
{
|
|
range: {
|
|
end: {
|
|
character: 31,
|
|
line: 6
|
|
},
|
|
start: {
|
|
character: 12,
|
|
line: 6
|
|
}
|
|
},
|
|
target: "https://www.github.com/actions/checkout/tree/v3/",
|
|
tooltip: "Open action on GitHub"
|
|
},
|
|
{
|
|
range: {
|
|
end: {
|
|
character: 40,
|
|
line: 7
|
|
},
|
|
start: {
|
|
character: 12,
|
|
line: 7
|
|
}
|
|
},
|
|
target: "https://www.github.com/github/codeql-action/tree/v2/init",
|
|
tooltip: "Open action on GitHub"
|
|
}
|
|
]);
|
|
});
|
|
|
|
it("links for reusable local workflow", async () => {
|
|
const input = `on: push
|
|
jobs:
|
|
build:
|
|
uses: ./.github/workflows/reusable-workflow.yml`;
|
|
const result = await documentLinks(createDocument("test.yaml", input), "file:///workspace/");
|
|
expect(result).toEqual([
|
|
{
|
|
range: {
|
|
end: {
|
|
character: 51,
|
|
line: 3
|
|
},
|
|
start: {
|
|
character: 10,
|
|
line: 3
|
|
}
|
|
},
|
|
target: "file:///workspace/.github/workflows/reusable-workflow.yml"
|
|
}
|
|
]);
|
|
});
|
|
|
|
it("links for reusable remote workflow", async () => {
|
|
const input = `on: push
|
|
jobs:
|
|
build:
|
|
uses: seismis-rainier/workflows/reusable-workflow.yml@main`;
|
|
const result = await documentLinks(createDocument("test.yaml", input), "file:///workspace/");
|
|
expect(result).toEqual([
|
|
{
|
|
range: {
|
|
end: {
|
|
character: 62,
|
|
line: 3
|
|
},
|
|
start: {
|
|
character: 10,
|
|
line: 3
|
|
}
|
|
},
|
|
target: "https://www.github.com/seismis-rainier/workflows/tree/main/reusable-workflow.yml",
|
|
tooltip: "Open reusable workflow on GitHub"
|
|
}
|
|
]);
|
|
});
|
|
});
|