eric scipleandGitHub
656a821a94
Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
36 lines
1.2 KiB
TypeScript
36 lines
1.2 KiB
TypeScript
import {TemplateContext} from "../../templates/template-context.js";
|
|
import {TemplateToken} from "../../templates/tokens/template-token.js";
|
|
import {isString} from "../../templates/tokens/type-guards.js";
|
|
import {ConcurrencySetting} from "../workflow-template.js";
|
|
|
|
export function convertConcurrency(context: TemplateContext, token: TemplateToken): ConcurrencySetting {
|
|
const result: ConcurrencySetting = {};
|
|
|
|
if (token.isExpression) {
|
|
return result;
|
|
}
|
|
if (isString(token)) {
|
|
result.group = token;
|
|
return result;
|
|
}
|
|
const concurrencyProperty = token.assertMapping("concurrency group");
|
|
for (const property of concurrencyProperty) {
|
|
const propertyName = property.key.assertString("concurrency group key");
|
|
if (property.key.isExpression || property.value.isExpression) {
|
|
continue;
|
|
}
|
|
switch (propertyName.value) {
|
|
case "group":
|
|
result.group = property.value.assertString("concurrency group");
|
|
break;
|
|
case "cancel-in-progress":
|
|
result.cancelInProgress = property.value.assertBoolean("cancel-in-progress").value;
|
|
break;
|
|
default:
|
|
context.error(propertyName, `Invalid property name: ${propertyName.value}`);
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|