eric scipleandGitHub
656a821a94
Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
82 lines
1.9 KiB
TypeScript
82 lines
1.9 KiB
TypeScript
import {Array} from "./array.js";
|
|
import {BooleanData} from "./boolean.js";
|
|
import {Dictionary} from "./dictionary.js";
|
|
import {ExpressionData} from "./expressiondata.js";
|
|
import {Null} from "./null.js";
|
|
import {NumberData} from "./number.js";
|
|
import {reviver} from "./reviver.js";
|
|
import {StringData} from "./string.js";
|
|
|
|
describe("reviver", () => {
|
|
const tests: {
|
|
name: string;
|
|
data: string;
|
|
want: ExpressionData;
|
|
}[] = [
|
|
{
|
|
name: "null",
|
|
data: "null",
|
|
want: new Null()
|
|
},
|
|
{
|
|
name: "number",
|
|
data: "1",
|
|
want: new NumberData(1)
|
|
},
|
|
{
|
|
name: "string",
|
|
data: `"a"`,
|
|
want: new StringData("a")
|
|
},
|
|
{
|
|
name: "true boolean",
|
|
data: "true",
|
|
want: new BooleanData(true)
|
|
},
|
|
{
|
|
name: "false boolean",
|
|
data: "false",
|
|
want: new BooleanData(false)
|
|
},
|
|
{
|
|
name: "array",
|
|
data: `[1,2,3]`,
|
|
want: new Array(new NumberData(1), new NumberData(2), new NumberData(3))
|
|
},
|
|
{
|
|
name: "nested array",
|
|
data: `[1,2,[3,4],5]`,
|
|
want: new Array(
|
|
new NumberData(1),
|
|
new NumberData(2),
|
|
new Array(new NumberData(3), new NumberData(4)),
|
|
new NumberData(5)
|
|
)
|
|
},
|
|
{
|
|
name: "complex array",
|
|
data: `[{"a":[true,2]},{"b":"three"},{"c":null}]`,
|
|
want: new Array(
|
|
new Dictionary({
|
|
key: "a",
|
|
value: new Array(new BooleanData(true), new NumberData(2))
|
|
}),
|
|
new Dictionary({key: "b", value: new StringData("three")}),
|
|
new Dictionary({key: "c", value: new Null()})
|
|
)
|
|
},
|
|
{
|
|
name: "dictionary",
|
|
data: `{ "object1": {} }`,
|
|
want: new Dictionary({
|
|
key: "object1",
|
|
value: new Dictionary()
|
|
})
|
|
}
|
|
];
|
|
|
|
test.each(tests)("$name", ({data, want}: {data: string; want: ExpressionData}) => {
|
|
expect(JSON.parse(data, reviver)).toEqual(want);
|
|
});
|
|
});
|