Files
languageservices/expressions/src/result.test.ts
T
eric sciple 656a821a94 ESM migration: Add .js extensions for node16 moduleResolution (#257)
Migrate expressions, workflow-parser, and languageservice packages to use
proper ESM imports with .js extensions that work with node16 moduleResolution.

Changes:
- Update tsconfig.build.json in each package to use module: node16 and
  moduleResolution: node16
- Add .js extensions to all relative import paths (Option B approach)
- Fix yaml internal type imports in workflow-parser by defining local types
- Add skipLibCheck to handle @types/node compatibility issues
- Add TypeScript 5.8.3 override in root package.json
- Add ESM migration plan documentation

The languageserver package is deferred due to test hang issues that need
further investigation.

Related #154 - Upgrade moduleResolution from node to node16 or nodenext
Related #110 - Published ESM code has imports without file extensions
Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example
Related #146 - Can not import @actions/workflow-parser

Test results:
- expressions: 1068 tests passed
- workflow-parser: 292 tests passed
- languageservice: 452 tests passed

* docs: update ESM migration plan with findings

- Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM
  exports (not a test hang issue)
- Document that Option B (manual .js extensions) was chosen over Option A
  due to ts-jest compatibility issues
- Add workaround for yaml package internal types (LinePos, NodeBase)
- Update migration status table with accurate reason for deferral
- Add skipLibCheck note for @types/node compatibility
2025-12-18 13:35:48 -06:00

99 lines
2.6 KiB
TypeScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
import {BooleanData, ExpressionData, NumberData, StringData} from "./data/index.js";
import {coerceTypes, toUpperSpecial} from "./result.js";
describe("coerceTypes", () => {
const tests: {
name: string;
data: {
l: ExpressionData;
r: ExpressionData;
};
wantL: ExpressionData;
wantR: ExpressionData;
}[] = [
{
name: "number-bool",
data: {l: new NumberData(1), r: new BooleanData(true)},
wantL: new NumberData(1),
wantR: new NumberData(1)
},
{
name: "number-bool-false",
data: {l: new NumberData(1), r: new BooleanData(false)},
wantL: new NumberData(1),
wantR: new NumberData(0)
},
{
name: "bool-number-false",
data: {l: new BooleanData(false), r: new NumberData(1)},
wantL: new NumberData(0),
wantR: new NumberData(1)
},
{
name: "number-number",
data: {l: new NumberData(1), r: new NumberData(2)},
wantL: new NumberData(1),
wantR: new NumberData(2)
},
{
name: "string-string",
data: {l: new StringData("a"), r: new StringData("b")},
wantL: new StringData("a"),
wantR: new StringData("b")
},
{
name: "string-number",
data: {l: new StringData("a"), r: new NumberData(1)},
wantL: new NumberData(NaN),
wantR: new NumberData(1)
},
{
name: "number-string",
data: {l: new NumberData(1), r: new StringData("a")},
wantL: new NumberData(1),
wantR: new NumberData(NaN)
},
{
name: "bool-bool",
data: {l: new BooleanData(false), r: new BooleanData(true)},
wantL: new BooleanData(false),
wantR: new BooleanData(true)
}
];
test.each(tests)(
"$name",
({
data,
wantL,
wantR
}: {
data: {l: ExpressionData; r: ExpressionData};
wantL: ExpressionData;
wantR: ExpressionData;
}) => {
const [gotL, gotR] = coerceTypes(data.l, data.r);
expect(gotL).toEqual(wantL);
expect(gotR).toEqual(wantR);
}
);
});
describe("toUpperSpecial", () => {
const tests: {input: string; want: string}[] = [
{input: "", want: ""},
{input: "abc", want: "ABC"},
{input: "ıabc", want: "ıABC"},
{input: "ııabc", want: "ııABC"},
{input: "abcı", want: "ABCı"},
{input: "abcıı", want: "ABCıı"},
{input: "abcıdef", want: "ABCıDEF"},
{input: "abcııdef", want: "ABCııDEF"},
{input: "abcıdefıghi", want: "ABCıDEFıGHI"}
];
test.each(tests)("$input", ({input, want}: {input: string; want: string}) => {
expect(toUpperSpecial(input)).toEqual(want);
});
});