eric scipleandGitHub
656a821a94
Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
36 lines
1.1 KiB
TypeScript
36 lines
1.1 KiB
TypeScript
import {ExpressionData, Kind, StringData} from "../data/index.js";
|
|
import {FunctionDefinition} from "./info.js";
|
|
|
|
export const join: FunctionDefinition = {
|
|
name: "join",
|
|
description:
|
|
"`join( array, optionalSeparator )`\n\nThe value for `array` can be an array or a string. All values in `array` are concatenated into a string. If you provide `optionalSeparator`, it is inserted between the concatenated values. Otherwise, the default separator `,` is used. Casts values to a string.",
|
|
minArgs: 1,
|
|
maxArgs: 2,
|
|
call: (...args: ExpressionData[]): ExpressionData => {
|
|
// Primitive
|
|
if (args[0].primitive) {
|
|
return new StringData(args[0].coerceString());
|
|
}
|
|
|
|
// Array
|
|
if (args[0].kind === Kind.Array) {
|
|
// Separator
|
|
let separator = ",";
|
|
if (args.length > 1 && args[1].primitive) {
|
|
separator = args[1].coerceString();
|
|
}
|
|
|
|
// Convert items to strings
|
|
return new StringData(
|
|
args[0]
|
|
.values()
|
|
.map(item => item.coerceString())
|
|
.join(separator)
|
|
);
|
|
}
|
|
|
|
return new StringData("");
|
|
}
|
|
};
|