eric sciple
656a821a94
Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
57 lines
1.8 KiB
TypeScript
57 lines
1.8 KiB
TypeScript
import {ErrorType, ExpressionError} from "./errors.js";
|
|
import {contains} from "./funcs/contains.js";
|
|
import {endswith} from "./funcs/endswith.js";
|
|
import {format} from "./funcs/format.js";
|
|
import {fromjson} from "./funcs/fromjson.js";
|
|
import {FunctionDefinition, FunctionInfo} from "./funcs/info.js";
|
|
import {join} from "./funcs/join.js";
|
|
import {startswith} from "./funcs/startswith.js";
|
|
import {tojson} from "./funcs/tojson.js";
|
|
import {Token} from "./lexer.js";
|
|
|
|
export type ParseContext = {
|
|
allowUnknownKeywords: boolean;
|
|
extensionContexts: Map<string, boolean>;
|
|
extensionFunctions: Map<string, FunctionInfo>;
|
|
};
|
|
|
|
export const wellKnownFunctions: {[name: string]: FunctionDefinition} = {
|
|
contains: contains,
|
|
endswith: endswith,
|
|
format: format,
|
|
fromjson: fromjson,
|
|
join: join,
|
|
startswith: startswith,
|
|
tojson: tojson
|
|
};
|
|
|
|
// validateFunction returns the function definition for the given function name.
|
|
// If the function does not exist or an incorrect number of arguments is provided,
|
|
// an error is returned.
|
|
export function validateFunction(context: ParseContext, identifier: Token, argCount: number) {
|
|
// Expression function names are case-insensitive.
|
|
const name = identifier.lexeme.toLowerCase();
|
|
|
|
let f: FunctionInfo | undefined;
|
|
f = wellKnownFunctions[name];
|
|
if (!f) {
|
|
f = context.extensionFunctions.get(name);
|
|
if (!f) {
|
|
if (!context.allowUnknownKeywords) {
|
|
throw new ExpressionError(ErrorType.ErrorUnrecognizedFunction, identifier);
|
|
}
|
|
|
|
// Skip argument validation for unknown functions
|
|
return;
|
|
}
|
|
}
|
|
|
|
if (argCount < f.minArgs) {
|
|
throw new ExpressionError(ErrorType.ErrorTooFewParameters, identifier);
|
|
}
|
|
|
|
if (argCount > f.maxArgs) {
|
|
throw new ExpressionError(ErrorType.ErrorTooManyParameters, identifier);
|
|
}
|
|
}
|