Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
54 lines
1.8 KiB
TypeScript
54 lines
1.8 KiB
TypeScript
import {DEFINITION, SEQUENCE, ITEM_TYPE} from "../template-constants.js";
|
|
import {MappingToken} from "../tokens/index.js";
|
|
import {Definition} from "./definition.js";
|
|
import {DefinitionType} from "./definition-type.js";
|
|
import {TemplateSchema} from "./template-schema.js";
|
|
|
|
export class SequenceDefinition extends Definition {
|
|
public itemType = "";
|
|
|
|
public constructor(key: string, definition?: MappingToken) {
|
|
super(key, definition);
|
|
if (definition) {
|
|
for (const definitionPair of definition) {
|
|
const definitionKey = definitionPair.key.assertString(`${DEFINITION} key`);
|
|
switch (definitionKey.value) {
|
|
case SEQUENCE: {
|
|
const mapping = definitionPair.value.assertMapping(`${DEFINITION} ${SEQUENCE}`);
|
|
for (const mappingPair of mapping) {
|
|
const mappingKey = mappingPair.key.assertString(`${DEFINITION} ${SEQUENCE} key`);
|
|
switch (mappingKey.value) {
|
|
case ITEM_TYPE: {
|
|
const itemType = mappingPair.value.assertString(`${DEFINITION} ${SEQUENCE} ${ITEM_TYPE}`);
|
|
this.itemType = itemType.value;
|
|
break;
|
|
}
|
|
default:
|
|
// throws
|
|
mappingKey.assertUnexpectedValue(`${DEFINITION} ${SEQUENCE} key`);
|
|
break;
|
|
}
|
|
}
|
|
break;
|
|
}
|
|
default:
|
|
definitionKey.assertUnexpectedValue(`${DEFINITION} key`); // throws
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
public override get definitionType(): DefinitionType {
|
|
return DefinitionType.Sequence;
|
|
}
|
|
|
|
public override validate(schema: TemplateSchema, name: string): void {
|
|
if (!this.itemType) {
|
|
throw new Error(`'${name}' does not defined '${ITEM_TYPE}'`);
|
|
}
|
|
|
|
// Lookup item type
|
|
schema.getDefinition(this.itemType);
|
|
}
|
|
}
|