eric scipleandGitHub
656a821a94
Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
64 lines
1.8 KiB
TypeScript
64 lines
1.8 KiB
TypeScript
import {hover} from "./hover.js";
|
|
import {testHoverConfig} from "./hover.test.js";
|
|
import {getPositionFromCursor} from "./test-utils/cursor-position.js";
|
|
import {clearCache} from "./utils/workflow-cache.js";
|
|
|
|
beforeEach(() => {
|
|
clearCache();
|
|
});
|
|
|
|
describe("hover.reusable-workflow", () => {
|
|
it("hover on job input with description", async () => {
|
|
const input = `
|
|
on: push
|
|
|
|
jobs:
|
|
build:
|
|
uses: ./.github/workflows/reusable-workflow-with-inputs.yaml
|
|
with:
|
|
us|ername:
|
|
`;
|
|
const result = await hover(...getPositionFromCursor(input), testHoverConfig("username", "scalar-needs-context"));
|
|
expect(result).not.toBeUndefined();
|
|
expect(result?.contents).toEqual(
|
|
"A username passed from the caller workflow\n\nAvailable expression contexts: `github`, `inputs`, `vars`, `needs`, `strategy`, `matrix`"
|
|
);
|
|
});
|
|
|
|
it("hover on job input without description", async () => {
|
|
const input = `
|
|
on: push
|
|
|
|
jobs:
|
|
build:
|
|
uses: ./.github/workflows/reusable-workflow-with-inputs-no-description.yaml
|
|
with:
|
|
us|ername:
|
|
`;
|
|
const result = await hover(...getPositionFromCursor(input));
|
|
expect(result).not.toBeUndefined();
|
|
expect(result?.contents).toEqual(
|
|
"Available expression contexts: `github`, `inputs`, `vars`, `needs`, `strategy`, `matrix`"
|
|
);
|
|
});
|
|
|
|
it("hover on job output with description", async () => {
|
|
const input = `
|
|
on: push
|
|
|
|
jobs:
|
|
build:
|
|
uses: ./.github/workflows/reusable-workflow-with-outputs.yaml
|
|
echo_outputs:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
steps:
|
|
- run: echo \${{ needs.build.outputs.bu|ild_id }}
|
|
`;
|
|
|
|
const result = await hover(...getPositionFromCursor(input), testHoverConfig("", "string-steps-context"));
|
|
expect(result).not.toBeUndefined();
|
|
expect(result?.contents).toEqual("The resulting build ID");
|
|
});
|
|
});
|