eric sciple
656a821a94
Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
76 lines
1.8 KiB
TypeScript
76 lines
1.8 KiB
TypeScript
import {getPositionFromCursor} from "../test-utils/cursor-position.js";
|
|
import {transform} from "./transform.js";
|
|
|
|
describe("transform", () => {
|
|
it("adds : at end of line", () => {
|
|
const [doc, pos] = getPositionFromCursor("on: push\njobs:\n build:\n runs-on|");
|
|
const [newDoc, newPos] = transform(doc, pos);
|
|
|
|
expect(newDoc.getText()).toEqual(`on: push
|
|
jobs:
|
|
build:
|
|
runs-on:`);
|
|
expect(newPos.character).toEqual(11);
|
|
});
|
|
|
|
it("adds : at end of line with trailing comment", () => {
|
|
const [doc, pos] = getPositionFromCursor("on: push\njobs:\n build:\n runs-on|\n#");
|
|
const [newDoc, newPos] = transform(doc, pos);
|
|
|
|
expect(newDoc.getText()).toEqual(`on: push
|
|
jobs:
|
|
build:
|
|
runs-on:
|
|
#`);
|
|
expect(newPos.character).toEqual(11);
|
|
});
|
|
|
|
it("adds placeholder node in empty sequence", () => {
|
|
const [doc, pos] = getPositionFromCursor(`on: push
|
|
jobs:
|
|
build:
|
|
runs-on:
|
|
- |`);
|
|
const [newDoc, newPos] = transform(doc, pos);
|
|
|
|
expect(newDoc.getText()).toEqual(`on: push
|
|
jobs:
|
|
build:
|
|
runs-on:
|
|
- key`);
|
|
expect(newPos.character).toEqual(9);
|
|
});
|
|
|
|
it("adds placeholder node in empty line", () => {
|
|
const [doc, pos] = getPositionFromCursor(`on: push
|
|
jobs:
|
|
build:
|
|
runs-on:
|
|
|`);
|
|
const [newDoc, newPos] = transform(doc, pos);
|
|
|
|
expect(newDoc.getText()).toEqual(`on: push
|
|
jobs:
|
|
build:
|
|
runs-on:
|
|
key:`);
|
|
expect(newPos.character).toEqual(7);
|
|
});
|
|
|
|
it("does not transform expression lines", () => {
|
|
const [doc, pos] = getPositionFromCursor(`on: push
|
|
jobs:
|
|
build:
|
|
runs-on:
|
|
\${{ github| }}`);
|
|
const [newDoc, newPos] = transform(doc, pos);
|
|
|
|
expect(newDoc.getText()).toEqual(`on: push
|
|
jobs:
|
|
build:
|
|
runs-on:
|
|
\${{ github }}`);
|
|
expect(newPos.character).toEqual(16);
|
|
});
|
|
});
|