eric scipleandGitHub
656a821a94
Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
42 lines
1.3 KiB
TypeScript
42 lines
1.3 KiB
TypeScript
import {isMapping, isString} from "@actions/workflow-parser";
|
|
import {DESCRIPTION} from "@actions/workflow-parser/templates/template-constants";
|
|
import {WorkflowContext} from "../context/workflow-context.js";
|
|
import {TokenResult} from "../utils/find-token.js";
|
|
|
|
export function isReusableWorkflowJobInput(tokenResult: TokenResult): boolean {
|
|
return (
|
|
tokenResult.parent?.definition?.key === "workflow-job-with" &&
|
|
tokenResult.token !== null &&
|
|
isString(tokenResult.token)
|
|
);
|
|
}
|
|
|
|
export function getReusableWorkflowInputDescription(
|
|
workflowContext: WorkflowContext,
|
|
tokenResult: TokenResult
|
|
): string {
|
|
const reusableWorkflowJob = workflowContext.reusableWorkflowJob;
|
|
|
|
if (!reusableWorkflowJob) {
|
|
return "";
|
|
}
|
|
|
|
const inputName = tokenResult.token && isString(tokenResult.token) && tokenResult.token.value;
|
|
if (!inputName) {
|
|
return "";
|
|
}
|
|
|
|
// Find the input description in the template, if any
|
|
if (reusableWorkflowJob["input-definitions"]) {
|
|
const definition = reusableWorkflowJob["input-definitions"].find(inputName);
|
|
if (definition && isMapping(definition)) {
|
|
const description = definition.find(DESCRIPTION);
|
|
if (description && isString(description)) {
|
|
return description.value;
|
|
}
|
|
}
|
|
}
|
|
|
|
return "";
|
|
}
|