656a821a94
Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
43 lines
1.2 KiB
TypeScript
43 lines
1.2 KiB
TypeScript
import {Dictionary} from "../data/dictionary.js";
|
|
import {ExpressionData, Kind, Pair} from "../data/expressiondata.js";
|
|
|
|
export type DescriptionPair = Pair & {description?: string};
|
|
|
|
export function isDescriptionDictionary(x: ExpressionData): x is DescriptionDictionary {
|
|
return x.kind === Kind.Dictionary && x instanceof DescriptionDictionary;
|
|
}
|
|
|
|
export class DescriptionDictionary extends Dictionary {
|
|
private readonly descriptions = new Map<string, string>();
|
|
public complete = true;
|
|
|
|
constructor(...pairs: DescriptionPair[]) {
|
|
super();
|
|
|
|
for (const p of pairs) {
|
|
this.add(p.key, p.value, p.description);
|
|
}
|
|
}
|
|
|
|
override add(key: string, value: ExpressionData, description?: string): void {
|
|
if (this.get(key) !== undefined) {
|
|
// Key already added, ignore
|
|
return;
|
|
}
|
|
|
|
super.add(key, value);
|
|
if (description) {
|
|
this.descriptions.set(key, description);
|
|
}
|
|
}
|
|
|
|
override pairs(): DescriptionPair[] {
|
|
const pairs = super.pairs();
|
|
return pairs.map(p => ({...p, description: this.descriptions.get(p.key)}));
|
|
}
|
|
|
|
getDescription(key: string): string | undefined {
|
|
return this.descriptions.get(key);
|
|
}
|
|
}
|