656a821a94
Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
180 lines
3.6 KiB
TypeScript
180 lines
3.6 KiB
TypeScript
import {DescriptionDictionary, isDescriptionDictionary} from "@actions/expressions";
|
|
import {testGetWorkflowContext} from "../test-utils/test-workflow-context.js";
|
|
import {Mode} from "./default.js";
|
|
import {getGithubContext} from "./github.js";
|
|
|
|
describe("github context", () => {
|
|
it("single event", async () => {
|
|
const workflowContext = await testGetWorkflowContext(`on: push
|
|
jobs:
|
|
build:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: ec|ho`);
|
|
|
|
const g = getGithubContext(workflowContext, Mode.Completion);
|
|
if (!isDescriptionDictionary(g)) {
|
|
fail();
|
|
}
|
|
|
|
const e = g.get("event") as DescriptionDictionary;
|
|
|
|
expect(e.pairs().map(p => p.key)).toEqual([
|
|
"after",
|
|
"base_ref",
|
|
"before",
|
|
"commits",
|
|
"compare",
|
|
"created",
|
|
"deleted",
|
|
"enterprise",
|
|
"forced",
|
|
"head_commit",
|
|
"installation",
|
|
"organization",
|
|
"pusher",
|
|
"ref",
|
|
"repository",
|
|
"sender"
|
|
]);
|
|
});
|
|
|
|
it("single event - multiple types", async () => {
|
|
const workflowContext = await testGetWorkflowContext(`
|
|
on:
|
|
pull_request:
|
|
types:
|
|
- 'synchronize'
|
|
- 'ready_for_review'
|
|
|
|
jobs:
|
|
build:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: ec|ho`);
|
|
|
|
const g = getGithubContext(workflowContext, Mode.Completion);
|
|
if (!isDescriptionDictionary(g)) {
|
|
fail();
|
|
}
|
|
|
|
const e = g.get("event") as DescriptionDictionary;
|
|
|
|
expect(e.pairs().map(p => p.key)).toEqual([
|
|
"action",
|
|
"after",
|
|
"before",
|
|
"enterprise",
|
|
"installation",
|
|
"number",
|
|
"organization",
|
|
"pull_request",
|
|
"repository",
|
|
"sender"
|
|
]);
|
|
});
|
|
|
|
it("single event - no default types", async () => {
|
|
const workflowContext = await testGetWorkflowContext(`
|
|
on:
|
|
issues:
|
|
|
|
jobs:
|
|
build:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: ec|ho`);
|
|
|
|
const g = getGithubContext(workflowContext, Mode.Completion);
|
|
if (!isDescriptionDictionary(g)) {
|
|
fail();
|
|
}
|
|
|
|
const e = g.get("event") as DescriptionDictionary;
|
|
const i = e.get("issue") as DescriptionDictionary;
|
|
|
|
expect(i.pairs().map(p => p.key)).toEqual([
|
|
"active_lock_reason",
|
|
"assignee",
|
|
"assignees",
|
|
"author_association",
|
|
"body",
|
|
"closed_at",
|
|
"comments",
|
|
"comments_url",
|
|
"created_at",
|
|
"draft",
|
|
"events_url",
|
|
"html_url",
|
|
"id",
|
|
"labels",
|
|
"labels_url",
|
|
"locked",
|
|
"milestone",
|
|
"node_id",
|
|
"number",
|
|
"performed_via_github_app",
|
|
"pull_request",
|
|
"reactions",
|
|
"repository_url",
|
|
"state",
|
|
"state_reason",
|
|
"timeline_url",
|
|
"title",
|
|
"updated_at",
|
|
"url",
|
|
"user"
|
|
]);
|
|
});
|
|
|
|
it("multiple events - multiple types", async () => {
|
|
const workflowContext = await testGetWorkflowContext(`
|
|
on:
|
|
push:
|
|
pull_request:
|
|
types:
|
|
- 'synchronize'
|
|
- 'ready_for_review'
|
|
|
|
jobs:
|
|
build:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: ec|ho`);
|
|
|
|
const g = getGithubContext(workflowContext, Mode.Completion);
|
|
if (!isDescriptionDictionary(g)) {
|
|
fail();
|
|
}
|
|
|
|
const e = g.get("event") as DescriptionDictionary;
|
|
|
|
expect(
|
|
e
|
|
.pairs()
|
|
.map(p => p.key)
|
|
.sort()
|
|
).toEqual([
|
|
"action",
|
|
"after",
|
|
"base_ref",
|
|
"before",
|
|
"commits",
|
|
"compare",
|
|
"created",
|
|
"deleted",
|
|
"enterprise",
|
|
"forced",
|
|
"head_commit",
|
|
"installation",
|
|
"number",
|
|
"organization",
|
|
"pull_request",
|
|
"pusher",
|
|
"ref",
|
|
"repository",
|
|
"sender"
|
|
]);
|
|
});
|
|
});
|