Migrate expressions, workflow-parser, and languageservice packages to use proper ESM imports with .js extensions that work with node16 moduleResolution. Changes: - Update tsconfig.build.json in each package to use module: node16 and moduleResolution: node16 - Add .js extensions to all relative import paths (Option B approach) - Fix yaml internal type imports in workflow-parser by defining local types - Add skipLibCheck to handle @types/node compatibility issues - Add TypeScript 5.8.3 override in root package.json - Add ESM migration plan documentation The languageserver package is deferred due to test hang issues that need further investigation. Related #154 - Upgrade moduleResolution from node to node16 or nodenext Related #110 - Published ESM code has imports without file extensions Related #64 - expressions: ERR_MODULE_NOT_FOUND attempting to run example Related #146 - Can not import @actions/workflow-parser Test results: - expressions: 1068 tests passed - workflow-parser: 292 tests passed - languageservice: 452 tests passed * docs: update ESM migration plan with findings - Update languageserver blocker: vscode-languageserver v8.0.2 lacks ESM exports (not a test hang issue) - Document that Option B (manual .js extensions) was chosen over Option A due to ts-jest compatibility issues - Add workaround for yaml package internal types (LinePos, NodeBase) - Update migration status table with accurate reason for deferral - Add skipLibCheck note for @types/node compatibility
170 lines
4.6 KiB
TypeScript
170 lines
4.6 KiB
TypeScript
import {complete} from "./complete.js";
|
|
import {TextDocument} from "vscode-languageserver-textdocument";
|
|
import {clearCache} from "./utils/workflow-cache.js";
|
|
import {getPositionFromCursor} from "./test-utils/cursor-position.js";
|
|
|
|
beforeEach(() => {
|
|
clearCache();
|
|
});
|
|
|
|
describe("Issue #81 - multi-line if expression completion", () => {
|
|
it("should complete in block scalar if with | (exact position)", async () => {
|
|
// Exact reproduction from issue - cursor after "github." in block scalar
|
|
const input = `on: push
|
|
|
|
jobs:
|
|
build:
|
|
if: |
|
|
github.
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: echo`;
|
|
|
|
const doc = TextDocument.create("file:///test.yaml", "yaml", 1, input);
|
|
// Line 5 (0-indexed) = " github.", character 13 = after the dot
|
|
const pos = {line: 5, character: 13};
|
|
|
|
const result = await complete(doc, pos, {});
|
|
|
|
expect(result.length).toBeGreaterThan(0);
|
|
expect(result.map(x => x.label)).toContain("event");
|
|
expect(result.map(x => x.label)).toContain("actor");
|
|
});
|
|
|
|
it("should complete in block scalar if with > (exact position)", async () => {
|
|
const input = `on: push
|
|
|
|
jobs:
|
|
build:
|
|
if: >
|
|
github.
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: echo`;
|
|
|
|
const doc = TextDocument.create("file:///test.yaml", "yaml", 1, input);
|
|
const pos = {line: 5, character: 13};
|
|
|
|
const result = await complete(doc, pos, {});
|
|
|
|
expect(result.length).toBeGreaterThan(0);
|
|
expect(result.map(x => x.label)).toContain("event");
|
|
});
|
|
|
|
it("should complete in block scalar with multiple lines", async () => {
|
|
const input = `on: push
|
|
jobs:
|
|
build:
|
|
if: |
|
|
github.event_name == 'push' &&
|
|
github.|
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: echo`;
|
|
|
|
// Skip 1 to skip the `|` block scalar indicator (same character as cursor marker)
|
|
const result = await complete(...getPositionFromCursor(input, 1), {});
|
|
|
|
expect(result.length).toBeGreaterThan(0);
|
|
expect(result.map(x => x.label)).toContain("event");
|
|
});
|
|
|
|
it("should complete step if in block scalar", async () => {
|
|
const input = `on: push
|
|
jobs:
|
|
build:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: echo
|
|
if: |
|
|
github.
|
|
`;
|
|
|
|
const doc = TextDocument.create("file:///test.yaml", "yaml", 1, input);
|
|
// Line 7 = " github.", character 15 = after the dot (8 spaces + 7 chars)
|
|
const pos = {line: 7, character: 15};
|
|
|
|
const result = await complete(doc, pos, {});
|
|
|
|
expect(result.length).toBeGreaterThan(0);
|
|
expect(result.map(x => x.label)).toContain("event");
|
|
});
|
|
|
|
it("should complete in block scalar with ${{ expression markers", async () => {
|
|
// This case works because transform() skips lines with ${{
|
|
// Note: Using explicit position because | appears in multiple places (block scalar, ||, cursor)
|
|
const input = `on: push
|
|
jobs:
|
|
build:
|
|
if: |
|
|
\${{
|
|
github.ref == 'refs/heads/main' ||
|
|
github.
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: echo`;
|
|
|
|
const doc = TextDocument.create("file:///test.yaml", "yaml", 1, input);
|
|
// Line 6 = " github." = 8 spaces + 7 chars = 15 chars, cursor after dot is at char 15
|
|
const pos = {line: 6, character: 15};
|
|
|
|
const result = await complete(doc, pos, {});
|
|
|
|
expect(result.length).toBeGreaterThan(0);
|
|
expect(result.map(x => x.label)).toContain("ref");
|
|
expect(result.map(x => x.label)).toContain("ref_name");
|
|
});
|
|
});
|
|
|
|
describe("Edge cases for getOffsetInContent", () => {
|
|
it("should complete in single-line if (not block scalar)", async () => {
|
|
const input = `on: push
|
|
jobs:
|
|
build:
|
|
if: github.|
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: echo`;
|
|
|
|
const result = await complete(...getPositionFromCursor(input), {});
|
|
|
|
expect(result.length).toBeGreaterThan(0);
|
|
expect(result.map(x => x.label)).toContain("event");
|
|
});
|
|
|
|
it("should complete on third content line of block scalar", async () => {
|
|
const input = `on: push
|
|
jobs:
|
|
build:
|
|
if: |
|
|
github.event_name == 'push' &&
|
|
github.ref == 'refs/heads/main' &&
|
|
github.|
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: echo`;
|
|
|
|
const result = await complete(...getPositionFromCursor(input, 1), {});
|
|
|
|
expect(result.length).toBeGreaterThan(0);
|
|
expect(result.map(x => x.label)).toContain("event");
|
|
});
|
|
|
|
it("should complete when block scalar has empty first line", async () => {
|
|
const input = `on: push
|
|
jobs:
|
|
build:
|
|
if: |
|
|
|
|
github.|
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: echo`;
|
|
|
|
const result = await complete(...getPositionFromCursor(input, 1), {});
|
|
|
|
expect(result.length).toBeGreaterThan(0);
|
|
expect(result.map(x => x.label)).toContain("event");
|
|
});
|
|
});
|