Improve auto-completion for expression functions

actions-languageservice/src/complete.expressions.test.ts

@@ -1,4 +1,5 @@
 import {data} from "@github/actions-expressions";
+import {CompletionItemKind} from "vscode-languageserver-types";
 import {complete, getExpressionInput} from "./complete";
 import {ContextProviderConfig} from "./context-providers/config";
 import {registerLogger} from "./log";
@@ -632,4 +633,37 @@ jobs:
       expect(result.map(x => x.label)).toEqual(["color"]);
     });
   });
+
+  it("context completion items include kind and insert text", async () => {
+    const input = `
+    on: push
+
+    jobs:
+      test:
+        runs-on: ubuntu-latest
+        steps:
+          - uses: actions/checkout@v3
+          - run: echo \${{ | }}.txt
+    `;
+
+    const result = await complete(...getPositionFromCursor(input), undefined, contextProviderConfig);
+
+    // Built-in function
+    const toJSON = result.find(x => x.label === "toJson");
+    expect(toJSON).toBeDefined();
+    expect(toJSON!.kind).toBe(CompletionItemKind.Function);
+    expect(toJSON!.insertText).toBe("toJson()");
+
+    // Function from context
+    const hashFiles = result.find(x => x.label === "hashFiles");
+    expect(hashFiles).toBeDefined();
+    expect(hashFiles!.kind).toBe(CompletionItemKind.Function);
+    expect(hashFiles!.insertText).toBe("hashFiles()");
+
+    // Not a function
+    const github = result.find(x => x.label === "github");
+    expect(github).toBeDefined();
+    expect(github!.kind).toBe(CompletionItemKind.Variable);
+    expect(github!.insertText).toBeUndefined();
+  });
 });