From e630928f559cfe223227a919aac8cb02518ec895 Mon Sep 17 00:00:00 2001 From: Christopher Schleiden Date: Wed, 30 Nov 2022 11:59:44 -0800 Subject: [PATCH] Best effort conversion when validating --- actions-languageservice/src/validate.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/actions-languageservice/src/validate.ts b/actions-languageservice/src/validate.ts index 2da881d..ec9c9c4 100644 --- a/actions-languageservice/src/validate.ts +++ b/actions-languageservice/src/validate.ts @@ -9,6 +9,7 @@ import { ParseWorkflowResult, WorkflowTemplate } from "@github/actions-workflow-parser"; +import {ErrorPolicy} from "@github/actions-workflow-parser/model/convert"; import {splitAllowedContext} from "@github/actions-workflow-parser/templates/allowed-context"; import {BasicExpressionToken} from "@github/actions-workflow-parser/templates/tokens/basic-expression-token"; import {StringToken} from "@github/actions-workflow-parser/templates/tokens/string-token"; @@ -49,8 +50,8 @@ export async function validate( try { const result: ParseWorkflowResult = parseWorkflow(file.name, [file], nullTrace); if (result.value) { - // Errors will be updated in the context - const template = convertWorkflowTemplate(result.context, result.value); + // Errors will be updated in the context. Attempt to do the conversion anyway in order to give the user more information + const template = convertWorkflowTemplate(result.context, result.value, ErrorPolicy.TryConversion); // Validate expressions and value providers await additionalValidations(