From bb9c7f16ba3c2d76180f5951ad0048f832f7bef1 Mon Sep 17 00:00:00 2001 From: Jacob Wallraff Date: Fri, 6 Jan 2023 13:32:53 -0800 Subject: [PATCH 1/3] Add hover property tests --- actions-languageservice/src/hover.test.ts | 26 +++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/actions-languageservice/src/hover.test.ts b/actions-languageservice/src/hover.test.ts index 2b00671..598ed0b 100644 --- a/actions-languageservice/src/hover.test.ts +++ b/actions-languageservice/src/hover.test.ts @@ -25,6 +25,32 @@ jobs: expect(result?.contents).toEqual("Runs your workflow when you push a commit or tag."); }); + + it("on a parameter with a description", async () => { + const input = `on: push +jobs: + build: + co|ntinue-on-error: false`; + const result = await hover(...getPositionFromCursor(input)); + expect(result).not.toBeUndefined(); + expect(result?.contents).toEqual( + "Prevents a workflow run from failing when a job fails. Set to true to allow a workflow run to pass when this job fails.\n\n" + + "**Context:** github, inputs, vars, needs, strategy, matrix" + ); + }); + + it("on a parameter with its own type", async () => { + const input = `on: push +jobs: + build: + pe|rmissions: read-all`; + const result = await hover(...getPositionFromCursor(input)); + expect(result).not.toBeUndefined(); + expect(result?.contents).toEqual( + "You can modify the default permissions granted to the GITHUB_TOKEN, adding or removing access as required, so that you only allow the minimum required access." + ); + }); + it("on a value in a sequence", async () => { const input = `on: [pull_request, pu|sh] From 40debd9c0b527ac9670aabbf4de58b9c78ec5fef Mon Sep 17 00:00:00 2001 From: Jacob Wallraff Date: Fri, 6 Jan 2023 14:11:51 -0800 Subject: [PATCH 2/3] Update package version --- package-lock.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index 6dc6a96..eac4640 100644 --- a/package-lock.json +++ b/package-lock.json @@ -702,9 +702,9 @@ "link": true }, "node_modules/@github/actions-workflow-parser": { - "version": "0.0.39", - "resolved": "https://npm.pkg.github.com/download/@github/actions-workflow-parser/0.0.39/ba3e9e02e489175e0f284f0aebd9bde92ad4e935", - "integrity": "sha512-Iw8OkCUxdgFvXpJkg6dAIEpGQrS09o3TC1I0looCJ1lHMBDBD7aVXasE8zJzlQUTdgRTGMiptNMgZS2MnGC76Q==", + "version": "0.0.41", + "resolved": "https://npm.pkg.github.com/download/@github/actions-workflow-parser/0.0.41/234e6042ee06199b4314589ad77dfd7fe0debe6d", + "integrity": "sha512-s27gUhNH80YhFmkcQ5GE5BA5D15xbQ48YjwKCwYKN+ndldaOhpqa+v5Q+NfZlNwBmJ/8lJZob09/IiGRgFq7ag==", "license": "MIT", "dependencies": { "@github/actions-expressions": "*", @@ -13565,9 +13565,9 @@ } }, "@github/actions-workflow-parser": { - "version": "0.0.39", - "resolved": "https://npm.pkg.github.com/download/@github/actions-workflow-parser/0.0.39/ba3e9e02e489175e0f284f0aebd9bde92ad4e935", - "integrity": "sha512-Iw8OkCUxdgFvXpJkg6dAIEpGQrS09o3TC1I0looCJ1lHMBDBD7aVXasE8zJzlQUTdgRTGMiptNMgZS2MnGC76Q==", + "version": "0.0.41", + "resolved": "https://npm.pkg.github.com/download/@github/actions-workflow-parser/0.0.41/234e6042ee06199b4314589ad77dfd7fe0debe6d", + "integrity": "sha512-s27gUhNH80YhFmkcQ5GE5BA5D15xbQ48YjwKCwYKN+ndldaOhpqa+v5Q+NfZlNwBmJ/8lJZob09/IiGRgFq7ag==", "requires": { "@github/actions-expressions": "*", "yaml": "^2.0.0-8" From f19616735d171d12013bb096b7729891cda08ad3 Mon Sep 17 00:00:00 2001 From: github-actions Date: Fri, 6 Jan 2023 22:31:36 +0000 Subject: [PATCH 3/3] v0.1.69 --- actions-languageserver/package.json | 4 ++-- actions-languageservice/package.json | 2 +- browser-playground/package.json | 4 ++-- lerna.json | 2 +- package-lock.json | 14 +++++++------- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/actions-languageserver/package.json b/actions-languageserver/package.json index 2637c10..8058ef4 100644 --- a/actions-languageserver/package.json +++ b/actions-languageserver/package.json @@ -1,6 +1,6 @@ { "name": "@github/actions-languageserver", - "version": "0.1.68", + "version": "0.1.69", "description": "Language server for GitHub Actions", "license": "MIT", "type": "module", @@ -38,7 +38,7 @@ "prettier-fix": "prettier --write ." }, "dependencies": { - "@github/actions-languageservice": "^0.1.68", + "@github/actions-languageservice": "^0.1.69", "@github/actions-workflow-parser": "*", "@octokit/rest": "^19.0.5", "vscode-languageserver": "^8.0.2", diff --git a/actions-languageservice/package.json b/actions-languageservice/package.json index 0b3ae2a..1329d06 100644 --- a/actions-languageservice/package.json +++ b/actions-languageservice/package.json @@ -1,6 +1,6 @@ { "name": "@github/actions-languageservice", - "version": "0.1.68", + "version": "0.1.69", "description": "Language service for GitHub Actions", "license": "MIT", "type": "module", diff --git a/browser-playground/package.json b/browser-playground/package.json index 046e698..d1d97aa 100644 --- a/browser-playground/package.json +++ b/browser-playground/package.json @@ -1,12 +1,12 @@ { "name": "browser-playground", - "version": "0.1.68", + "version": "0.1.69", "description": "", "private": true, "main": "index.js", "type": "module", "dependencies": { - "@github/actions-languageserver": "^0.1.68", + "@github/actions-languageserver": "^0.1.69", "monaco-editor-webpack-plugin": "^7.0.1", "monaco-editor-workers": "^0.34.2", "monaco-languageclient": "^4.0.3", diff --git a/lerna.json b/lerna.json index 2038758..c0af9d1 100644 --- a/lerna.json +++ b/lerna.json @@ -1,5 +1,5 @@ { "$schema": "node_modules/lerna/schemas/lerna-schema.json", "useWorkspaces": true, - "version": "0.1.68" + "version": "0.1.69" } diff --git a/package-lock.json b/package-lock.json index eac4640..4358410 100644 --- a/package-lock.json +++ b/package-lock.json @@ -16,10 +16,10 @@ }, "actions-languageserver": { "name": "@github/actions-languageserver", - "version": "0.1.68", + "version": "0.1.69", "license": "MIT", "dependencies": { - "@github/actions-languageservice": "^0.1.68", + "@github/actions-languageservice": "^0.1.69", "@github/actions-workflow-parser": "*", "@octokit/rest": "^19.0.5", "vscode-languageserver": "^8.0.2", @@ -41,7 +41,7 @@ }, "actions-languageservice": { "name": "@github/actions-languageservice", - "version": "0.1.68", + "version": "0.1.69", "license": "MIT", "dependencies": { "@github/actions-expressions": "*", @@ -63,10 +63,10 @@ } }, "browser-playground": { - "version": "0.1.68", + "version": "0.1.69", "license": "MIT", "dependencies": { - "@github/actions-languageserver": "^0.1.68", + "@github/actions-languageserver": "^0.1.69", "monaco-editor-webpack-plugin": "^7.0.1", "monaco-editor-workers": "^0.34.2", "monaco-languageclient": "^4.0.3", @@ -13533,7 +13533,7 @@ "@github/actions-languageserver": { "version": "file:actions-languageserver", "requires": { - "@github/actions-languageservice": "^0.1.68", + "@github/actions-languageservice": "^0.1.69", "@github/actions-workflow-parser": "*", "@octokit/rest": "^19.0.5", "@types/jest": "^29.0.3", @@ -16320,7 +16320,7 @@ "browser-playground": { "version": "file:browser-playground", "requires": { - "@github/actions-languageserver": "^0.1.68", + "@github/actions-languageserver": "^0.1.69", "css-loader": "^6.7.2", "monaco-editor-webpack-plugin": "^7.0.1", "monaco-editor-workers": "^0.34.2",