From d7b582c975990f8edfe87cb5c767aad41be61fb3 Mon Sep 17 00:00:00 2001 From: Jacob Wallraff Date: Tue, 21 Feb 2023 15:58:45 -0800 Subject: [PATCH] Don't add context to expression hover --- actions-languageservice/src/hover.reusable-workflow.test.ts | 6 ++---- actions-languageservice/src/hover.ts | 6 +----- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/actions-languageservice/src/hover.reusable-workflow.test.ts b/actions-languageservice/src/hover.reusable-workflow.test.ts index 37ef45b..31f9154 100644 --- a/actions-languageservice/src/hover.reusable-workflow.test.ts +++ b/actions-languageservice/src/hover.reusable-workflow.test.ts @@ -2,7 +2,7 @@ import {hover} from "./hover"; import {testHoverConfig} from "./hover.test"; import {getPositionFromCursor} from "./test-utils/cursor-position"; -describe("hover on reusable workflows", () => { +describe("hover.reusable-workflow", () => { it("hover on job input with description", async () => { const input = ` on: push @@ -51,8 +51,6 @@ jobs: const result = await hover(...getPositionFromCursor(input), testHoverConfig("", "string-steps-context")); expect(result).not.toBeUndefined(); - expect(result?.contents).toEqual( - "The resulting build ID\n\n**Context:** github, inputs, vars, needs, strategy, matrix, secrets, steps, job, runner, env, hashFiles(1,255)" - ); + expect(result?.contents).toEqual("The resulting build ID"); }); }); diff --git a/actions-languageservice/src/hover.ts b/actions-languageservice/src/hover.ts index 263fd88..6a073eb 100644 --- a/actions-languageservice/src/hover.ts +++ b/actions-languageservice/src/hover.ts @@ -67,11 +67,7 @@ export async function hover(document: TextDocument, position: Position, config?: const exprPos = mapToExpressionPos(token, position); if (exprPos) { - let hover = expressionHover(exprPos, context, namedContexts, functions); - if (hover) { - hover.contents = appendContext(hover.contents as string, allowedContext); - } - return hover; + return expressionHover(exprPos, context, namedContexts, functions); } } }