From cc316ab9dea2d77763691fd3d7cd5e120fe15724 Mon Sep 17 00:00:00 2001 From: eric sciple Date: Fri, 3 Apr 2026 18:33:15 -0500 Subject: [PATCH] Remove phantom github.job_workflow_sha from language service (#347) This property is listed in the GitHub context provider but is never populated at runtime by the runner. Users see it in autocomplete, use it in workflows, and it silently evaluates to empty string. Remove from keys array and description metadata. --- languageservice/src/context-providers/descriptions.json | 7 ------- languageservice/src/context-providers/github.ts | 1 - 2 files changed, 8 deletions(-) diff --git a/languageservice/src/context-providers/descriptions.json b/languageservice/src/context-providers/descriptions.json index ddeeb79..b43af22 100644 --- a/languageservice/src/context-providers/descriptions.json +++ b/languageservice/src/context-providers/descriptions.json @@ -105,13 +105,6 @@ "job": { "description": "The [`job_id`](https://docs.github.com/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_id) of the current job.\nNote: This context property is set by the Actions runner, and is only available within the execution `steps` of a job. Otherwise, the value of this property will be `null`." }, - "job_workflow_sha": { - "description": "For jobs using a reusable workflow, the commit SHA for the reusable workflow file.", - "versions": { - "ghes": ">=3.9", - "ghae": ">=3.9" - } - }, "path": { "description": "Path on the runner to the file that sets system PATH variables from workflow commands. This file is unique to the current step and is a different file for each step in a job. For more information, see \"[Workflow commands for GitHub Actions](https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-system-path).\"" }, diff --git a/languageservice/src/context-providers/github.ts b/languageservice/src/context-providers/github.ts index 55dac9e..8c29cc9 100644 --- a/languageservice/src/context-providers/github.ts +++ b/languageservice/src/context-providers/github.ts @@ -29,7 +29,6 @@ export function getGithubContext(workflowContext: WorkflowContext | undefined, m "graphql_url", "head_ref", "job", - "job_workflow_sha", "path", "ref", "ref_name",