actions/languageservices
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor template job filtering

Browse Source
This commit is contained in:
Jacob Wallraff
2023-02-17 12:54:59 -08:00
parent 050634415e
commit c5caf4b35f
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
actions-languageservice/src/hover.ts
+4 -4
View File
@@ -26,6 +26,7 @@ import {nullTrace} from "./nulltrace";
import {isPotentiallyExpression} from "./utils/expression-detection"; import {isPotentiallyExpression} from "./utils/expression-detection";
import {findToken, TokenResult} from "./utils/find-token"; import {findToken, TokenResult} from "./utils/find-token";
import {mapRange} from "./utils/range"; import {mapRange} from "./utils/range";
import { ReusableWorkflowJob } from "@github/actions-workflow-parser/model/workflow-template";
export type HoverConfig = { export type HoverConfig = {
descriptionProvider?: DescriptionProvider; descriptionProvider?: DescriptionProvider;
@@ -206,11 +207,10 @@ function getReusableWorkflowInputDescription(workflowContext: WorkflowContext, t
return ""; return "";
} }
// Filter out just reusable jobs
const templateJobs = template.jobs.filter(isReusableWorkflowJob);
// Find the reusable job in the template that matches the current reusable job // Find the reusable job in the template that matches the current reusable job
const templateJob = templateJobs.find(job => job.id.value === reusableWorkflowJob!.id.value); const templateJob = template.jobs.find(job => {
return isReusableWorkflowJob(job) && job.id.value === reusableWorkflowJob.id.value
}) as ReusableWorkflowJob
// Find the input description in the template, if any // Find the input description in the template, if any
if (templateJob && reusableWorkflowJob["input-definitions"] && templateJob["input-definitions"]) { if (templateJob && reusableWorkflowJob["input-definitions"] && templateJob["input-definitions"]) {