From b2f9502197ace01339375e830677014bd0b96244 Mon Sep 17 00:00:00 2001 From: Chris Sidi Date: Mon, 23 Jan 2023 23:11:29 -0500 Subject: [PATCH] Remove warnings for the SuggestedValues provider (i.e. `runs-on`) --- actions-languageservice/src/validate.test.ts | 32 ++------------------ actions-languageservice/src/validate.ts | 8 +---- 2 files changed, 3 insertions(+), 37 deletions(-) diff --git a/actions-languageservice/src/validate.test.ts b/actions-languageservice/src/validate.test.ts index ea0e993..05b8514 100644 --- a/actions-languageservice/src/validate.test.ts +++ b/actions-languageservice/src/validate.test.ts @@ -73,21 +73,7 @@ jobs: {valueProviderConfig: defaultValueProviders} ); - expect(result.length).toBe(1); - expect(result[0]).toEqual({ - message: "Value 'does-not-exist' might not be valid", - severity: DiagnosticSeverity.Warning, - range: { - end: { - character: 27, - line: 3 - }, - start: { - character: 13, - line: 3 - } - } - } as Diagnostic); + expect(result.length).toBe(0); }); it("value in sequence not returned by value provider", async () => { @@ -106,21 +92,7 @@ jobs: {valueProviderConfig: defaultValueProviders} ); - expect(result.length).toBe(1); - expect(result[0]).toEqual({ - message: "Value 'does-not-exist' might not be valid", - severity: DiagnosticSeverity.Warning, - range: { - end: { - character: 20, - line: 5 - }, - start: { - character: 6, - line: 5 - } - } - } as Diagnostic); + expect(result.length).toBe(0); }); it("single value not returned by allowed value provider", async () => { diff --git a/actions-languageservice/src/validate.ts b/actions-languageservice/src/validate.ts index 0f82985..4f727d9 100644 --- a/actions-languageservice/src/validate.ts +++ b/actions-languageservice/src/validate.ts @@ -150,13 +150,7 @@ function invalidValue(diagnostics: Diagnostic[], token: StringToken, kind: Value }); break; - case ValueProviderKind.SuggestedValues: - diagnostics.push({ - message: `Value '${token.value}' might not be valid`, - severity: DiagnosticSeverity.Warning, - range: mapRange(token.range) - }); - break; + // no messages for SuggestedValues } }