actions/languageservices
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Completion bug with null string (#168)

Browse Source
This commit is contained in:
Laura Yu
2023-02-28 10:18:46 -08:00
committed by GitHub
parent 437a4151e4
commit b21c0e461d
3 changed files with 31 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
languageservice/src/utils/expression-detection.ts
+1 -1
View File
@@ -7,6 +7,6 @@ import {TemplateToken} from "@github/actions-workflow-parser/templates/tokens/in
export function isPotentiallyExpression(token: TemplateToken): boolean {
const isAlwaysExpression =
token.definition?.definitionType === DefinitionType.String && (token.definition as StringDefinition).isExpression;
const containsExpression = isString(token) && token.value.indexOf(OPEN_EXPRESSION) >= 0;
const containsExpression = isString(token) && token.value != null && token.value.indexOf(OPEN_EXPRESSION) >= 0;
return isAlwaysExpression || containsExpression;
}