From 9f5d9a024ddfbe6fdb4de3be0e2c70b9c2d15070 Mon Sep 17 00:00:00 2001
From: Jonathan Tamsut <jtamsut@users.noreply.github.com>
Date: Fri, 4 Aug 2023 11:14:06 -0700
Subject: [PATCH] revert newline for string and boolean types

---
 languageservice/src/complete.test.ts              | 12 ------------
 languageservice/src/value-providers/definition.ts |  4 ----
 2 files changed, 16 deletions(-)

diff --git a/languageservice/src/complete.test.ts b/languageservice/src/complete.test.ts
index 060d9da..d1e65ff 100644
--- a/languageservice/src/complete.test.ts
+++ b/languageservice/src/complete.test.ts
@@ -474,15 +474,3 @@ jobs:
       expect(result.filter(x => x.label === "concurrency").map(x => x.textEdit?.newText)).toEqual(["concurrency"]);
     });
   });
-
-  it("adds a new line and indentation for mapping keys", async () => {
-    const input = "concurrency: |";
-
-    const result = await complete(...getPositionFromCursor(input));
-
-    expect(result.filter(x => x.label === "cancel-in-progress").map(x => x.textEdit?.newText)).toEqual([
-      "\n  cancel-in-progress: "
-    ]);
-    expect(result.filter(x => x.label === "group").map(x => x.textEdit?.newText)).toEqual(["\n  group: "]);
-  });
-});
diff --git a/languageservice/src/value-providers/definition.ts b/languageservice/src/value-providers/definition.ts
index 059a204..eb78d6e 100644
--- a/languageservice/src/value-providers/definition.ts
+++ b/languageservice/src/value-providers/definition.ts
@@ -71,10 +71,6 @@ function mappingValues(
             // No special insertText in this case
             break;
 
-          case DefinitionType.String:
-          case DefinitionType.Boolean:
-            insertText = `\n${indentation}${key}: `;
-            break;
           default:
             insertText = `${key}: `;
         }