actions/languageservices
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use const for default value providers

Browse Source
This commit is contained in:
Christopher Schleiden
2022-11-23 14:34:44 -08:00
parent a6cc41d6ff
commit 94fffed2a7
3 changed files with 28 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
actions-languageservice/src/complete.ts
+7 -17
View File
@@ -1,15 +1,8 @@
import {complete as completeExpression} from "@github/actions-expressions";
import {
convertWorkflowTemplate,
isMapping,
isSequence,
isString,
parseWorkflow,
} from "@github/actions-workflow-parser";
import {convertWorkflowTemplate, isMapping, isSequence, isString, parseWorkflow} from "@github/actions-workflow-parser";
import {CLOSE_EXPRESSION, OPEN_EXPRESSION} from "@github/actions-workflow-parser/templates/template-constants";
import {TemplateToken} from "@github/actions-workflow-parser/templates/tokens/index";
import {MappingToken} from "@github/actions-workflow-parser/templates/tokens/mapping-token";
import {SequenceToken} from "@github/actions-workflow-parser/templates/tokens/sequence-token";
import {TokenType} from "@github/actions-workflow-parser/templates/tokens/types";
import {File} from "@github/actions-workflow-parser/workflows/file";
import {Position, TextDocument} from "vscode-languageserver-textdocument";
@@ -109,21 +102,18 @@ async function getValues(
const existingValues = getExistingValues(token, parent, parentKey);
let customValues: Value[] | undefined = undefined;
if (token?.definition?.key) {
customValues = await valueProviderConfig?.getCustomValues(token.definition.key, workflowContext);
}
const customValues = await valueProviderConfig?.getCustomValues(token.definition.key, workflowContext);
if (customValues !== undefined) {
return filterAndSortCompletionOptions(customValues, existingValues);
if (customValues) {
return filterAndSortCompletionOptions(customValues, existingValues);
}
}
const valueProviders = defaultValueProviders(workflowContext);
// Use the value provider from the parent if we don't have a value provider for the current key
const valueProvider =
(token?.definition?.key && valueProviders[token.definition.key]) ||
(parent.definition?.key && valueProviders[parent.definition.key]);
(token?.definition?.key && defaultValueProviders[token.definition.key]) ||
(parent.definition?.key && defaultValueProviders[parent.definition.key]);
if (valueProvider) {
const values = valueProvider();