Remove unused code and address feedback

languageservice/src/complete.ts

@@ -70,7 +70,7 @@ export async function complete(
     return [];
   }
 
-  const template = await fetchOrConvertWorkflowTemplate(file, parsedWorkflow, textDocument.uri, config, {
+  const template = await fetchOrConvertWorkflowTemplate(parsedWorkflow, textDocument.uri, config, {
     fetchReusableWorkflowDepth: config?.fileProvider ? 1 : 0,
     errorPolicy: ErrorPolicy.TryConversion
   });

languageservice/src/document-links.ts

@@ -18,7 +18,7 @@ export async function documentLinks(document: TextDocument): Promise<DocumentLin
     return [];
   }
 
-  const template = await fetchOrConvertWorkflowTemplate(file, parsedWorkflow, document.uri, undefined, {
+  const template = await fetchOrConvertWorkflowTemplate(parsedWorkflow, document.uri, undefined, {
     errorPolicy: ErrorPolicy.TryConversion
   });
 

languageservice/src/hover.ts

@@ -48,7 +48,7 @@ export async function hover(document: TextDocument, position: Position, config?:
     return null;
   }
 
-  const template = await fetchOrConvertWorkflowTemplate(file, parsedWorkflow, document.uri, config, {
+  const template = await fetchOrConvertWorkflowTemplate(parsedWorkflow, document.uri, config, {
     errorPolicy: ErrorPolicy.TryConversion,
     fetchReusableWorkflowDepth: config?.fileProvider ? 1 : 0
   });

languageservice/src/utils/workflow-cache.ts

@@ -27,7 +27,7 @@ export function clearWorkflowTemplateCache() {
 
 export function fetchOrParseWorkflow(file: File, uri: string): ParseWorkflowResult | undefined {
   let result = parsedWorkflowCache.get(uri);
-  if (!result || !result.value) {
+  if (!result?.value) {
     result = parseWorkflow(file, nullTrace);
     if (!result.value) {
       return undefined;
@@ -38,7 +38,6 @@ export function fetchOrParseWorkflow(file: File, uri: string): ParseWorkflowResu
 }
 
 export async function fetchOrConvertWorkflowTemplate(
-  file: File,
   parsedWorkflow: ParseWorkflowResult,
   uri: string,
   config?: CompletionConfig,

languageservice/src/validate.ts

@@ -53,7 +53,7 @@ export async function validate(textDocument: TextDocument, config?: ValidationCo
 
     if (parsedWorkflow.value) {
       // Errors will be updated in the context. Attempt to do the conversion anyway in order to give the user more information
-      const template = await fetchOrConvertWorkflowTemplate(file, parsedWorkflow, textDocument.uri, config, {
+      const template = await fetchOrConvertWorkflowTemplate(parsedWorkflow, textDocument.uri, config, {
         fetchReusableWorkflowDepth: config?.fileProvider ? 1 : 0,
         errorPolicy: ErrorPolicy.TryConversion
       });

workflow-parser/README.md

@@ -38,7 +38,7 @@ jobs:
 `convertWorkflowTemplate` then takes that intermediate representation and converts it to a [`WorkflowTemplate`](./src/workflow-template.ts) object, which is a more convenient representation for working with workflows.
 
 ```typescript
-const workflowTemplate = await convertWorkflowTemplate("test.yaml", result.context, result.value);
+const workflowTemplate = await convertWorkflowTemplate(result.context, result.value);
 
 // workflowTemplate.jobs[0].id === "build"
 // workflowTemplate.jobs[0].steps[0].run === "echo 'hello'"

workflow-parser/src/model/convert.ts

@@ -11,8 +11,6 @@ import {convertReferencedWorkflow} from "./converter/referencedWorkflow";
 import {isReusableWorkflowJob} from "./type-guards";
 import {WorkflowTemplate} from "./workflow-template";
 
-const workflowTemplateCache = new Map<string, WorkflowTemplate>();
-
 export enum ErrorPolicy {
   ReturnErrorsOnly,
   TryConversion