From 4dd678cf30711029a749c3df4ffb7d2a9ca3c17e Mon Sep 17 00:00:00 2001 From: eric sciple Date: Thu, 4 Dec 2025 13:31:20 -0600 Subject: [PATCH] Improve cron schedule warning message (#227) --- languageservice/src/validate.test.ts | 5 +++-- languageservice/src/validate.ts | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/languageservice/src/validate.test.ts b/languageservice/src/validate.test.ts index 06d79cf..367c39e 100644 --- a/languageservice/src/validate.test.ts +++ b/languageservice/src/validate.test.ts @@ -211,7 +211,8 @@ jobs: expect(result.length).toBe(1); expect(result[0]).toEqual({ - message: "Runs every minute. Note: Actions schedules run at most every 5 minutes.", + message: + 'Actions schedules run at most every 5 minutes. "*/1 * * * *" (runs every minute) will not run as frequently as specified.', severity: DiagnosticSeverity.Warning, code: "on-schedule", codeDescription: { @@ -281,7 +282,7 @@ jobs: expect(result.length).toBe(1); expect(result[0]?.severity).toBe(DiagnosticSeverity.Warning); - expect(result[0]?.message).toContain("Note: Actions schedules run at most every 5 minutes."); + expect(result[0]?.message).toContain("Actions schedules run at most every 5 minutes."); }); it("invalid YAML", async () => { diff --git a/languageservice/src/validate.ts b/languageservice/src/validate.ts index 3f565d3..f81c836 100644 --- a/languageservice/src/validate.ts +++ b/languageservice/src/validate.ts @@ -247,7 +247,7 @@ function validateCronExpression(diagnostics: Diagnostic[], token: StringToken): // Check if the cron specifies an interval less than 5 minutes if (hasCronIntervalLessThan5Minutes(cronValue)) { diagnostics.push({ - message: `${description}. Note: Actions schedules run at most every 5 minutes.`, + message: `Actions schedules run at most every 5 minutes. "${cronValue}" (${description.toLowerCase()}) will not run as frequently as specified.`, range: mapRange(token.range), severity: DiagnosticSeverity.Warning, code: "on-schedule",