From 40c20d550471d499626f4b2b843ae34fcc8402b5 Mon Sep 17 00:00:00 2001 From: Felipe Suero Date: Tue, 2 May 2023 11:22:00 -0400 Subject: [PATCH] handle the edge-cases --- .../src/context-providers/secrets.ts | 25 +++---------------- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/languageserver/src/context-providers/secrets.ts b/languageserver/src/context-providers/secrets.ts index a641f07..365c423 100644 --- a/languageserver/src/context-providers/secrets.ts +++ b/languageserver/src/context-providers/secrets.ts @@ -45,40 +45,21 @@ export async function getSecrets( if (isString(workflowContext.job.environment)) { environmentName = workflowContext.job.environment.value; } else if (isMapping(workflowContext.job.environment)) { - for (const x of workflowContext.job.environment) { - if (isString(x.key) && x.key.value === "name") { - if (isString(x.value)) { - environmentName = x.value.value; - } - break; - } - } - } - } - - let isDynamicEnv = true; - - if (workflowContext?.job?.environment) { - if (isMapping(workflowContext.job.environment)) { for (const x of workflowContext.job.environment) { if (isString(x.key) && x.key.value === "name") { if (isString(x.value)) { environmentName = x.value.value; } else { - isDynamicEnv = true; + secretsContext.complete = false; } break; } } + } else { + secretsContext.complete = false; } } - console.log(`isDynamicEnv: ${isDynamicEnv}`) - console.log(`environmentName: ${environmentName}`) - // if (isDynamicEnv) { - secretsContext.complete = false; - return secretsContext; - // } const secrets = await getRemoteSecrets(octokit, cache, repo, environmentName);