From 1e4b7f6015e1bfd630ef4072f6fab6a8388a757d Mon Sep 17 00:00:00 2001 From: Josh Gross Date: Tue, 7 Feb 2023 11:21:06 -0500 Subject: [PATCH] Validate inputs when none are defined --- actions-workflow-parser/src/model/converter/job/inputs.ts | 2 +- .../reader/errors-reusable-workflow-job-inputs-undefined.yml | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/actions-workflow-parser/src/model/converter/job/inputs.ts b/actions-workflow-parser/src/model/converter/job/inputs.ts index 6b5d366..92a6b88 100644 --- a/actions-workflow-parser/src/model/converter/job/inputs.ts +++ b/actions-workflow-parser/src/model/converter/job/inputs.ts @@ -32,7 +32,7 @@ export function convertWorkflowJobInputs(context: TemplateContext, job: Reusable if (inputValues !== undefined) { for (const [_, [name, value]] of inputValues) { - if (inputDefinitions !== undefined && !inputDefinitions.has(name.toLowerCase())) { + if (inputDefinitions === undefined || !inputDefinitions.has(name.toLowerCase())) { context.error(value, `Invalid input, ${name} is not defined in the referenced workflow.`); } } diff --git a/actions-workflow-parser/testdata/reader/errors-reusable-workflow-job-inputs-undefined.yml b/actions-workflow-parser/testdata/reader/errors-reusable-workflow-job-inputs-undefined.yml index 7611a4c..87c5b82 100644 --- a/actions-workflow-parser/testdata/reader/errors-reusable-workflow-job-inputs-undefined.yml +++ b/actions-workflow-parser/testdata/reader/errors-reusable-workflow-job-inputs-undefined.yml @@ -1,7 +1,6 @@ include-source: false # Drop file/line/col from output skip: - Go - - TypeScript --- on: push jobs: