From 496000437366f09b3bfdecdd4d4a25b39d31c67f Mon Sep 17 00:00:00 2001 From: Josh Gross Date: Tue, 6 Dec 2022 11:33:04 -0500 Subject: [PATCH 1/3] Update references to Job `needs` --- actions-languageservice/src/context-providers/needs.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/actions-languageservice/src/context-providers/needs.ts b/actions-languageservice/src/context-providers/needs.ts index 559aa94..92ec131 100644 --- a/actions-languageservice/src/context-providers/needs.ts +++ b/actions-languageservice/src/context-providers/needs.ts @@ -10,8 +10,8 @@ export function getNeedsContext(workflowContext: WorkflowContext): data.Dictiona } for (const jobID of workflowContext.job.needs) { - const job = workflowContext.template?.jobs.find(job => job.id.value === jobID); - d.add(jobID, needsJobContext(job)); + const job = workflowContext.template?.jobs.find(job => job.id.value === jobID.value); + d.add(jobID.value, needsJobContext(job)); } return d; From 94c358933c603f1916d29a524655579d037ce0e9 Mon Sep 17 00:00:00 2001 From: Josh Gross Date: Tue, 6 Dec 2022 12:58:45 -0500 Subject: [PATCH 2/3] Update package version --- package-lock.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index 0b24bfe..3dee0cb 100644 --- a/package-lock.json +++ b/package-lock.json @@ -665,9 +665,9 @@ "link": true }, "node_modules/@github/actions-workflow-parser": { - "version": "0.0.25", - "resolved": "https://npm.pkg.github.com/download/@github/actions-workflow-parser/0.0.25/4ee85278c517247654ab7d5d91dce58176648bf8", - "integrity": "sha512-fq3kL5cUofMyN3djR4wCTfzNzLumYfn0anDvPcbat2iu7LyWxJmB12xNdwoR+t63tVEWbOcP9YP2DB0lWnnp5w==", + "version": "0.0.27", + "resolved": "https://npm.pkg.github.com/download/@github/actions-workflow-parser/0.0.27/7da28182bb856a124acf10ae60d6c1eab80a21cd", + "integrity": "sha512-EKnGr8C2Fe8ksswJXJoewcVtOEJcebDJRHZhgkIhDT74GTLZpXfBbE+tYzQaj2cVu6jylV27oj2otwHYNWSTGA==", "license": "MIT", "dependencies": { "@github/actions-expressions": "*", @@ -10927,9 +10927,9 @@ } }, "@github/actions-workflow-parser": { - "version": "0.0.25", - "resolved": "https://npm.pkg.github.com/download/@github/actions-workflow-parser/0.0.25/4ee85278c517247654ab7d5d91dce58176648bf8", - "integrity": "sha512-fq3kL5cUofMyN3djR4wCTfzNzLumYfn0anDvPcbat2iu7LyWxJmB12xNdwoR+t63tVEWbOcP9YP2DB0lWnnp5w==", + "version": "0.0.27", + "resolved": "https://npm.pkg.github.com/download/@github/actions-workflow-parser/0.0.27/7da28182bb856a124acf10ae60d6c1eab80a21cd", + "integrity": "sha512-EKnGr8C2Fe8ksswJXJoewcVtOEJcebDJRHZhgkIhDT74GTLZpXfBbE+tYzQaj2cVu6jylV27oj2otwHYNWSTGA==", "requires": { "@github/actions-expressions": "*", "yaml": "^2.0.0-8" From 1e0af9a9825f77133d206cd50e554278929af633 Mon Sep 17 00:00:00 2001 From: Josh Gross Date: Tue, 6 Dec 2022 13:05:41 -0500 Subject: [PATCH 3/3] Fix allowed value provider test --- actions-languageservice/src/validate.test.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/actions-languageservice/src/validate.test.ts b/actions-languageservice/src/validate.test.ts index d10116e..44beb3a 100644 --- a/actions-languageservice/src/validate.test.ts +++ b/actions-languageservice/src/validate.test.ts @@ -142,7 +142,6 @@ jobs: defaultValueProviders ); - expect(result.length).toBe(1); expect(result[0]).toEqual({ message: "Value 'test2' is not valid", severity: DiagnosticSeverity.Error,