Files
itgmania212121/src/RageSoundReader_Merge.cpp
T
sukibaby 2feb9e784c RageSoundReader_Merge fixes
This is the fixed Merge from the 2025-1-26 test build. It will more strictly check the drift with each iteration of the m_aSounds loop, whereas the original implementation can allow small amounts of desync to accumulate over time if none of them exceed the threshold.
2025-03-02 09:13:31 -08:00

329 lines
11 KiB
C++

#include "global.h"
#include "RageSoundReader_Merge.h"
#include "RageSoundReader_Resample_Good.h"
#include "RageSoundReader_Pan.h"
#include "RageLog.h"
#include "RageUtil.h"
#include "RageSoundMixBuffer.h"
#include "RageSoundUtil.h"
#include <cmath>
#include <vector>
RageSoundReader_Merge::RageSoundReader_Merge()
{
m_iSampleRate = -1;
m_iChannels = 0;
m_iNextSourceFrame = 0;
m_fCurrentStreamToSourceRatio = 1.0f;
}
RageSoundReader_Merge::~RageSoundReader_Merge()
{
for (RageSoundReader *it : m_aSounds)
delete it;
}
RageSoundReader_Merge::RageSoundReader_Merge( const RageSoundReader_Merge &cpy ):
RageSoundReader(cpy)
{
m_iSampleRate = cpy.m_iSampleRate;
m_iChannels = cpy.m_iChannels;
m_iNextSourceFrame = cpy.m_iNextSourceFrame;
m_fCurrentStreamToSourceRatio = cpy.m_fCurrentStreamToSourceRatio;
for (RageSoundReader const *it : cpy.m_aSounds)
m_aSounds.push_back( it->Copy() );
}
void RageSoundReader_Merge::AddSound( RageSoundReader *pSound )
{
m_aSounds.push_back( pSound );
}
/* If every sound has the same sample rate, return it. Otherwise, return -1. */
int RageSoundReader_Merge::GetSampleRateInternal() const
{
// TODO: Convert to a set and compare values?
int iRate = -1;
for (RageSoundReader const *it : m_aSounds)
{
if( iRate == -1 )
iRate = it->GetSampleRate();
else if( iRate != it->GetSampleRate() )
return -1;
}
return iRate;
}
void RageSoundReader_Merge::Finish( int iPreferredSampleRate )
{
/* Figure out how many channels we have. All sounds must either have 1 or 2 channels,
* which will be converted as needed, or have the same number of channels. */
m_iChannels = 1;
for (RageSoundReader *it : m_aSounds)
m_iChannels = std::max( m_iChannels, it->GetNumChannels() );
/*
* We might get different sample rates from our sources. If they're all the same
* sample rate, just leave it alone, so the whole sound can be resampled as a group.
* If not, resample eveything to the preferred rate. (Using the preferred rate
* should avoid redundant resampling later.)
*/
m_iSampleRate = GetSampleRateInternal();
if( m_iSampleRate == -1 )
{
for (RageSoundReader *it : m_aSounds)
{
RageSoundReader_Resample_Good *pResample = new RageSoundReader_Resample_Good( it, iPreferredSampleRate );
it = pResample;
}
m_iSampleRate = iPreferredSampleRate;
}
/* If we have two channels, and any sounds have only one, convert them by adding a Pan filter. */
for (RageSoundReader *it : m_aSounds)
{
if( it->GetNumChannels() != this->GetNumChannels() )
it = new RageSoundReader_Pan( it );
}
/* If we have more than two channels, then all sounds must have the same number of
* channels. */
if( m_iChannels > 2 )
{
std::vector<RageSoundReader *> aSounds;
for (RageSoundReader *it : m_aSounds)
{
if( it->GetNumChannels() != m_iChannels )
{
LOG->Warn( "Discarded sound with %i channels, not %i",
it->GetNumChannels(), m_iChannels );
delete it;
it = nullptr;
}
else
{
aSounds.push_back( it );
}
}
m_aSounds = aSounds;
}
}
int RageSoundReader_Merge::SetPosition( int iFrame )
{
m_iNextSourceFrame = iFrame;
int iRet = 0;
for( int i = 0; i < (int) m_aSounds.size(); ++i )
{
RageSoundReader *pSound = m_aSounds[i];
int iThisRet = pSound->SetPosition( iFrame );
if( iThisRet == -1 )
return -1;
if( iThisRet > 0 )
iRet = 1;
}
return iRet;
}
bool RageSoundReader_Merge::SetProperty( const RString &sProperty, float fValue )
{
bool bRet = false;
for( unsigned i = 0; i < m_aSounds.size(); ++i )
{
if( m_aSounds[i]->SetProperty(sProperty, fValue) )
bRet = true;
}
return bRet;
}
static float Difference( float a, float b ) { return std::abs( a - b ); }
static int Difference( int a, int b ) { return std::abs( a - b ); }
/*
* If the audio position drifts apart further than ERROR_CORRECTION_THRESHOLD frames,
* attempt to resync it.
*
* Frames are expressed as whole numbers, and the ratio between source and stream frames
* is floating point. We can't read a specific number of source frames, only stream
* frames. If a stream is early by 15 source frames, we'll convert that to stream
* frames for reading; this rounds back to an integer, so it isn't exact. (The amount
* of error should be no more than the ratio; if we have a ratio of 10, then reading
* 10 stream frames should advance the stream by 100-110 frames. The ratio is normally
* less than 5.)
*
* ERROR_CORRECTION_THRESHOLD should be greater than the maximum rate in use, so we
* can always resync the stream back to within the tolerance of the threshold.
*
* In the pathological case, if this is too low we may never resync properly, each
* attempt to resync leapfrogging past the previous.
*/
static const int ERROR_CORRECTION_THRESHOLD = 16;
/* As we iterate through the sound tree, we'll find that we need data from different
* sounds; a sound may be needed by more than one other sound. */
int RageSoundReader_Merge::Read( float *pBuffer, int iFrames )
{
if( m_aSounds.empty() )
{
return END_OF_FILE;
}
/*
* All sounds which are active should stay aligned; each GetNextSourceFrame should not
* come out of sync. Accomodate small rounding errors. A larger inconsistency
* happens may be a bug, such as sounds at different speeds.
*/
std::vector<int> aNextSourceFrames(m_aSounds.size());
std::vector<float> aRatios(m_aSounds.size());
for (size_t i = 0; i < m_aSounds.size(); ++i)
{
aNextSourceFrames[i] = m_aSounds[i]->GetNextSourceFrame();
aRatios[i] = m_aSounds[i]->GetStreamToSourceRatio();
}
/* GetNextSourceFrame for each active sound should be the same. If any differ,
* delay the later sounds until the earlier ones catch back up to put them
* back in sync. */
int iEarliestSound = std::distance(aNextSourceFrames.begin(), std::min_element(aNextSourceFrames.begin(), aNextSourceFrames.end()));
/* Normally, m_iNextSourceFrame should already be aligned with the GetNextSourceFrame of our
* sounds. If it's not, adjust it and return. */
if( m_iNextSourceFrame != aNextSourceFrames[iEarliestSound] ||
m_fCurrentStreamToSourceRatio != aRatios[iEarliestSound] )
{
m_iNextSourceFrame = aNextSourceFrames[iEarliestSound];
m_fCurrentStreamToSourceRatio = aRatios[iEarliestSound];
return 0;
}
int iMinPosition = aNextSourceFrames[iEarliestSound];
for (size_t i = 0; i < m_aSounds.size(); ++i)
{
if (Difference(aNextSourceFrames[i], iMinPosition) > ERROR_CORRECTION_THRESHOLD)
{
/* A sound is being delayed to resync it; clamp the number of frames we
* read now, so we don't advance past it. */
int iMaxSourceFramesToRead = aNextSourceFrames[i] - iMinPosition;
int iMaxStreamFramesToRead = static_cast<int>((iMaxSourceFramesToRead / m_fCurrentStreamToSourceRatio) + 0.5 );
iFrames = std::min( iFrames, iMaxStreamFramesToRead );
// LOG->Warn( "RageSoundReader_Merge: sound positions moving at different rates" );
}
}
// Read directly if there's only one sound
if( m_aSounds.size() == 1 )
{
RageSoundReader *pSound = m_aSounds.front();
iFrames = pSound->Read( pBuffer, iFrames );
if( iFrames > 0 )
{
m_iNextSourceFrame += static_cast<int>((iFrames * m_fCurrentStreamToSourceRatio) + 0.5 );
}
return iFrames;
}
RageSoundMixBuffer mix;
float Buffer[2048];
iFrames = std::min(iFrames, static_cast<int>(ARRAYLEN(Buffer) / m_iChannels));
/* Read iFrames from each sound. */
for (size_t i = 0; i < m_aSounds.size(); ++i)
{
RageSoundReader *pSound = m_aSounds[i];
ASSERT( pSound->GetNumChannels() == m_iChannels );
int iFramesRead = 0;
while( iFramesRead < iFrames )
{
// if( i == 0 )
//LOG->Trace( "*** %i", Difference(aNextSourceFrames[i], m_iNextSourceFrame + std::lrint(iFramesRead * aRatios[i])) );
// if( Difference(aNextSourceFrames[i], m_iNextSourceFrame + static_cast<int>((iFramesRead * aRatios[i]) + 0.5)) > ERROR_CORRECTION_THRESHOLD )
// {
// LOG->Trace("Sound positions moving at different rates");
// break;
// }
int iGotFrames = pSound->Read( Buffer, iFrames - iFramesRead );
aNextSourceFrames[i] = m_aSounds[i]->GetNextSourceFrame();
aRatios[i] = m_aSounds[i]->GetStreamToSourceRatio();
// LOG->Trace( "read %i from %i; %i -> %i", iGotFrames, i, oldf, aNextSourceFrames[i] );
if( iGotFrames < 0 )
{
if( i == 0 )
{
return iGotFrames;
}
break;
}
mix.SetWriteOffset( iFramesRead * pSound->GetNumChannels() );
mix.write( Buffer, iGotFrames * pSound->GetNumChannels() );
iFramesRead += iGotFrames;
if( Difference(aRatios[i], m_fCurrentStreamToSourceRatio) > 0.001f )
{
break;
}
}
}
/* Read mixed frames into the output buffer. */
int iMaxFramesRead = mix.size() / m_iChannels;
mix.read( pBuffer );
m_iNextSourceFrame += static_cast<int>(( iMaxFramesRead * m_fCurrentStreamToSourceRatio ) + 0.5);
return iMaxFramesRead;
}
int RageSoundReader_Merge::GetLength() const
{
int iLength = 0;
for( unsigned i = 0; i < m_aSounds.size(); ++i )
iLength = std::max( iLength, m_aSounds[i]->GetLength() );
return iLength;
}
int RageSoundReader_Merge::GetLength_Fast() const
{
int iLength = 0;
for( unsigned i = 0; i < m_aSounds.size(); ++i )
iLength = std::max( iLength, m_aSounds[i]->GetLength_Fast() );
return iLength;
}
/*
* Copyright (c) 2004-2006 Glenn Maynard
* All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the
* "Software"), to deal in the Software without restriction, including
* without limitation the rights to use, copy, modify, merge, publish,
* distribute, and/or sell copies of the Software, and to permit persons to
* whom the Software is furnished to do so, provided that the above
* copyright notice(s) and this permission notice appear in all copies of
* the Software and that both the above copyright notice(s) and this
* permission notice appear in supporting documentation.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF
* THIRD PARTY RIGHTS. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR HOLDERS
* INCLUDED IN THIS NOTICE BE LIABLE FOR ANY CLAIM, OR ANY SPECIAL INDIRECT
* OR CONSEQUENTIAL DAMAGES, OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS
* OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
* OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
* PERFORMANCE OF THIS SOFTWARE.
*/