From ff3b8bacbc0a8be0a4517bb52ef0ca3ee870207e Mon Sep 17 00:00:00 2001 From: Steve Checkoway Date: Mon, 24 Jul 2006 09:57:13 +0000 Subject: [PATCH] Fix sscanf() overflow issues. --- stepmania/src/ModelTypes.cpp | 4 ++-- stepmania/src/RageModelGeometry.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/stepmania/src/ModelTypes.cpp b/stepmania/src/ModelTypes.cpp index 6c5bb7aad3..1710527323 100644 --- a/stepmania/src/ModelTypes.cpp +++ b/stepmania/src/ModelTypes.cpp @@ -264,7 +264,7 @@ bool msAnimation::LoadMilkshapeAsciiBones( RString sAniName, RString sPath ) // name if( f.GetLine( sLine ) <= 0 ) THROW; - if (sscanf (sLine, "\"%[^\"]\"", szName) != 1) + if (sscanf (sLine, "\"%31[^\"]\"", szName) != 1) THROW; Bone.sName = szName; @@ -272,7 +272,7 @@ bool msAnimation::LoadMilkshapeAsciiBones( RString sAniName, RString sPath ) if( f.GetLine( sLine ) <= 0 ) THROW; strcpy (szName, ""); - sscanf (sLine, "\"%[^\"]\"", szName); + sscanf (sLine, "\"%31[^\"]\"", szName); Bone.sParentName = szName; diff --git a/stepmania/src/RageModelGeometry.cpp b/stepmania/src/RageModelGeometry.cpp index d6848f22fe..6859838542 100644 --- a/stepmania/src/RageModelGeometry.cpp +++ b/stepmania/src/RageModelGeometry.cpp @@ -142,7 +142,7 @@ void RageModelGeometry::LoadMilkshapeAscii( const RString& _sPath, bool bNeedsNo THROW; // mesh: name, flags, material index - if( sscanf (sLine, "\"%[^\"]\" %d %d",szName, &nFlags, &nIndex) != 3 ) + if( sscanf (sLine, "\"%31[^\"]\" %d %d",szName, &nFlags, &nIndex) != 3 ) THROW; mesh.sName = szName;