From 464f0f703bd2a1dc771c6ef4ecbc9541600f0df9 Mon Sep 17 00:00:00 2001 From: Colby Klein Date: Mon, 2 May 2011 10:36:08 -0700 Subject: [PATCH 1/2] PulseAudio has some issue which causes arrows to stutter. --- src/arch/Sound/RageSoundDriver_PulseAudio.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/arch/Sound/RageSoundDriver_PulseAudio.cpp b/src/arch/Sound/RageSoundDriver_PulseAudio.cpp index d639cd8287..4252ce27f6 100644 --- a/src/arch/Sound/RageSoundDriver_PulseAudio.cpp +++ b/src/arch/Sound/RageSoundDriver_PulseAudio.cpp @@ -79,7 +79,7 @@ RString RageSoundDriver_PulseAudio::Init() #endif pa_context_set_state_callback(m_PulseCtx, StaticCtxStateCb, this); - + LOG->Trace("Pulse: pa_context_connect()..."); error = pa_context_connect(m_PulseCtx, NULL, (pa_context_flags_t)0, NULL); @@ -299,6 +299,11 @@ int64_t RageSoundDriver_PulseAudio::GetPosition() const return m_LastPosition; } +/* + * XXX: Something here is slow and causes arrows to stutter in gameplay. + * This needs to be looked into (and for some reason the ALSA driver is + * useless on my laptop. - Colby + */ void RageSoundDriver_PulseAudio::StreamWriteCb(pa_stream *s, size_t length) { #if PA_API_VERSION <= 11 @@ -359,4 +364,4 @@ void RageSoundDriver_PulseAudio::StaticStreamWriteCb(pa_stream *s, size_t length * OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR * OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR * PERFORMANCE OF THIS SOFTWARE. - */ \ No newline at end of file + */ From d69bbdbb9d7a5808d8d52cdffaa7c59511558fb4 Mon Sep 17 00:00:00 2001 From: Colby Klein Date: Mon, 2 May 2011 10:41:59 -0700 Subject: [PATCH 2/2] Fix typo --- src/arch/Sound/RageSoundDriver_PulseAudio.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/arch/Sound/RageSoundDriver_PulseAudio.cpp b/src/arch/Sound/RageSoundDriver_PulseAudio.cpp index 4252ce27f6..54bfc8474f 100644 --- a/src/arch/Sound/RageSoundDriver_PulseAudio.cpp +++ b/src/arch/Sound/RageSoundDriver_PulseAudio.cpp @@ -302,7 +302,7 @@ int64_t RageSoundDriver_PulseAudio::GetPosition() const /* * XXX: Something here is slow and causes arrows to stutter in gameplay. * This needs to be looked into (and for some reason the ALSA driver is - * useless on my laptop. - Colby + * useless on my laptop). - Colby */ void RageSoundDriver_PulseAudio::StreamWriteCb(pa_stream *s, size_t length) {