actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up three sets of warnings:

Browse Source 
* Ensure all switches have a default when working with enums.
* Match defined new[] calls with delete[] calls.
* Respect variable initialization order.
This commit is contained in:
Jason Felds
2016-03-24 18:30:29 -04:00
parent 6a73cdd1ba
commit edabf4605b
19 changed files with 221 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ThemeManager.cpp
+17 -16
View File
@@ -688,14 +688,15 @@ bool ThemeManager::GetPathInfoToRaw( PathInfo &out, const RString &sThemeName_,
switch( LuaHelpers::ReportScriptError(message, "", true) )
{
case Dialog::abort:
RageException::Throw( "%s", message.c_str() );
break;
case Dialog::retry:
ReloadMetrics();
return GetPathInfoToRaw( out, sThemeName_, category, sMetricsGroup_, sElement_ );
case Dialog::ignore:
break;
case Dialog::abort:
RageException::Throw( "%s", message.c_str() );
break;
case Dialog::retry:
ReloadMetrics();
return GetPathInfoToRaw( out, sThemeName_, category, sMetricsGroup_, sElement_ );
case Dialog::ignore:
default:
break;
}
}
@@ -733,15 +734,15 @@ bool ThemeManager::GetPathInfoToRaw( PathInfo &out, const RString &sThemeName_,
switch(LuaHelpers::ReportScriptError(sMessage, "", true))
{
case Dialog::retry:
ReloadMetrics();
return GetPathInfoToRaw( out, sThemeName_, category, sMetricsGroup_, sElement_ );
case Dialog::ignore:
GetPathInfo( out, category, "", "_missing" );
return true;
case Dialog::retry:
ReloadMetrics();
return GetPathInfoToRaw( out, sThemeName_, category, sMetricsGroup_, sElement_ );
case Dialog::ignore:
GetPathInfo( out, category, "", "_missing" );
return true;
default:
RageException::Throw( "%s", sMessage.c_str() );
}
RageException::Throw( "%s", sMessage.c_str() );
}
bool ThemeManager::GetPathInfoToAndFallback( PathInfo &out, ElementCategory category, const RString &sMetricsGroup_, const RString &sElement )