actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up three sets of warnings:

Browse Source 
* Ensure all switches have a default when working with enums.
* Match defined new[] calls with delete[] calls.
* Respect variable initialization order.
This commit is contained in:
Jason Felds
2016-03-24 18:30:29 -04:00
parent 6a73cdd1ba
commit edabf4605b
19 changed files with 221 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/NoteDisplay.cpp
+20
View File
@@ -360,6 +360,8 @@ void NoteColumnRenderArgs::spae_pos_for_beat(const PlayerState* player_state,
case NCSM_Position:
pos_handler->EvalForBeat(song_beat, beat, sp_pos);
break;
default:
break;
}
}
void NoteColumnRenderArgs::spae_zoom_for_beat(const PlayerState* state, float beat,
@@ -377,6 +379,8 @@ void NoteColumnRenderArgs::spae_zoom_for_beat(const PlayerState* state, float be
case NCSM_Position:
zoom_handler->EvalForBeat(song_beat, beat, sp_zoom);
break;
default:
break;
}
}
void NoteColumnRenderArgs::SetPRZForActor(Actor* actor,
@@ -893,6 +897,8 @@ void NoteDisplay::DrawHoldPart(vector<Sprite*> &vpSpr,
column_args.pos_handler->EvalDerivForBeat(column_args.song_beat, cur_beat, sp_pos_forward);
RageVec3Normalize(&sp_pos_forward, &sp_pos_forward);
break;
default:
break;
}
render_forward.x+= sp_pos_forward.x;
@@ -918,6 +924,8 @@ void NoteDisplay::DrawHoldPart(vector<Sprite*> &vpSpr,
column_args.zoom_handler->EvalForBeat(column_args.song_beat, cur_beat, sp_zoom);
render_width= fFrameWidth * sp_zoom.x;
break;
default:
break;
}
const float fFrameWidthScale = ArrowEffects::GetFrameWidthScale(m_pPlayerState, fYOffset, part_args.overlapped_time);
@@ -938,6 +946,8 @@ void NoteDisplay::DrawHoldPart(vector<Sprite*> &vpSpr,
case NCSM_Position:
column_args.rot_handler->EvalForBeat(column_args.song_beat, cur_beat, sp_rot);
break;
default:
break;
}
RageVector3 center_vert(sp_pos.x + ae_pos.x,
@@ -1300,6 +1310,8 @@ void NoteDisplay::DrawActor(const TapNote& tn, Actor* pActor, NotePart part,
case NCSM_Position:
column_args.rot_handler->EvalForBeat(column_args.song_beat, spline_beat, sp_rot);
break;
default:
break;
}
column_args.spae_zoom_for_beat(m_pPlayerState, spline_beat, sp_zoom, ae_zoom);
column_args.SetPRZForActor(pActor, sp_pos, ae_pos, sp_rot, ae_rot, sp_zoom, ae_zoom);
@@ -1447,6 +1459,8 @@ void NoteColumnRenderer::UpdateReceptorGhostStuff(Actor* receptor) const
case NCSM_Position:
NCR_current.m_pos_handler.EvalForReceptor(song_beat, sp_pos);
break;
default:
break;
}
switch(NCR_current.m_rot_handler.m_spline_mode)
{
@@ -1460,6 +1474,8 @@ void NoteColumnRenderer::UpdateReceptorGhostStuff(Actor* receptor) const
case NCSM_Position:
NCR_current.m_rot_handler.EvalForReceptor(song_beat, sp_rot);
break;
default:
break;
}
switch(NCR_current.m_zoom_handler.m_spline_mode)
{
@@ -1473,6 +1489,8 @@ void NoteColumnRenderer::UpdateReceptorGhostStuff(Actor* receptor) const
case NCSM_Position:
NCR_current.m_zoom_handler.EvalForReceptor(song_beat, sp_zoom);
break;
default:
break;
}
m_column_render_args.SetPRZForActor(receptor, sp_pos, ae_pos, sp_rot, ae_rot, sp_zoom, ae_zoom);
receptor->SetInternalDiffuse(m_column_render_args.diffuse);
@@ -1524,6 +1542,8 @@ void NoteColumnRenderer::DrawPrimitives()
holds[tn.pn].push_back(begin);
}
break;
default:
break;
}
}
#define DTS_INNER(pn, tap_set, draw_func, disp) \