actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix repeated slow updates

Browse Source 
fix memory leak (apToDelete[i] was not actually being deleted)
This commit is contained in:
Glenn Maynard
2007-01-19 06:39:43 +00:00
parent 58bb20d6b3
commit e4ea02f177
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/SongManager.cpp
+14 -2
View File
@@ -1611,10 +1611,22 @@ void SongManager::FreeAllLoadedFromProfile( ProfileSlot slot )
apToDelete.push_back( *c ); apToDelete.push_back( *c );
} }
// XXX: this will update best, etc. every time; too slow /* We don't use DeleteCourse here, so we don't UpdatePopular and UpdateShuffled
* repeatedly. */
for( unsigned i = 0; i < apToDelete.size(); ++i ) for( unsigned i = 0; i < apToDelete.size(); ++i )
this->DeleteCourse( apToDelete[i] ); {
vector<Course*>::iterator iter = find( m_pCourses.begin(), m_pCourses.end(), apToDelete[i] );
ASSERT( iter != m_pCourses.end() );
m_pCourses.erase( iter );
delete apToDelete[i];
}
/* Popular and Shuffled may refer to courses that we just freed. */
UpdatePopular();
UpdateShuffled();
RefreshCourseGroupInfo();
/* Free profile steps. */
FOREACH( Song*, m_pSongs, s ) FOREACH( Song*, m_pSongs, s )
(*s)->FreeAllLoadedFromProfile( slot ); (*s)->FreeAllLoadedFromProfile( slot );