war on -Werror, part 8: more informals.

General guide: if the parameter name and its typings
match almost exactly, the name goes away.
Otherwise, it's commented out to allow for some
documentation.
This commit is contained in:
Jason Felds
2012-12-27 00:00:28 -05:00
parent 4f07a0ea8b
commit e01537405f
25 changed files with 85 additions and 80 deletions
+4 -4
View File
@@ -158,7 +158,7 @@ public:
RString OptionTitle() const;
RString GetThemedItemText( int iChoice ) const;
virtual void LoadInternal( const Commands &cmds ) { }
virtual void LoadInternal( const Commands & ) { }
/* We may re-use OptionRowHandlers. This is called before each use. If the
* contents of the row are dependent on external state (for example, the
@@ -173,11 +173,11 @@ public:
virtual ReloadChanged Reload() { return RELOAD_CHANGED_NONE; }
virtual int GetDefaultOption() const { return -1; }
virtual void ImportOption( OptionRow *pRow, const vector<PlayerNumber> &vpns, vector<bool> vbSelectedOut[NUM_PLAYERS] ) const { }
virtual void ImportOption( OptionRow *, const vector<PlayerNumber> &, vector<bool> vbSelectedOut[NUM_PLAYERS] ) const { }
// Returns an OPT mask.
virtual int ExportOption( const vector<PlayerNumber> &vpns, const vector<bool> vbSelected[NUM_PLAYERS] ) const { return 0; }
virtual int ExportOption( const vector<PlayerNumber> &, const vector<bool> vbSelected[NUM_PLAYERS] ) const { return 0; }
virtual void GetIconTextAndGameCommand( int iFirstSelection, RString &sIconTextOut, GameCommand &gcOut ) const;
virtual RString GetScreen( int iChoice ) const { return RString(); }
virtual RString GetScreen( int /* iChoice */ ) const { return RString(); }
};
/** @brief Utilities for the OptionRowHandlers. */