From dacf87fb3bd5d8e377096251da49fd45c3abdec2 Mon Sep 17 00:00:00 2001
From: sukibaby <163092272+sukibaby@users.noreply.github.com>
Date: Tue, 29 Apr 2025 23:15:01 -0700
Subject: [PATCH] SaveScreenshot: improve error logging

The existing code uses repeated error messages at different points in the code, making debugging very difficult. This makes every step more unique for easier state tracking. Also changes trace to warn, to make it a little easier to spot failed screenshots in the log.
---
 src/RageDisplay.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/RageDisplay.cpp b/src/RageDisplay.cpp
index fbf54cbf66..d3e523f978 100644
--- a/src/RageDisplay.cpp
+++ b/src/RageDisplay.cpp
@@ -775,7 +775,7 @@ bool RageDisplay::SaveScreenshot( RString sPath, GraphicsFileFormat format )
 
 	if (nullptr == surface)
 	{
-		LOG->Trace("CreateScreenshot failed to return a surface");
+		LOG->Warn("SaveScreenshot: failed to create a screenshot surface");
 		return false;
 	}
 
@@ -798,7 +798,7 @@ bool RageDisplay::SaveScreenshot( RString sPath, GraphicsFileFormat format )
 	RageFile out;
 	if( !out.Open( sPath, RageFile::WRITE ) )
 	{
-		LOG->Trace("Couldn't write %s: %s", sPath.c_str(), out.GetError().c_str() );
+		LOG->Warn("SaveScreenshot: Failed to open %s for writing: %s", sPath.c_str(), out.GetError().c_str() );
 		RageUtil::SafeDelete( surface );
 		return false;
 	}
@@ -828,7 +828,7 @@ bool RageDisplay::SaveScreenshot( RString sPath, GraphicsFileFormat format )
 
 	if( !bSuccess )
 	{
-		LOG->Trace("Couldn't write %s: %s", sPath.c_str(), out.GetError().c_str() );
+		LOG->Warn("SaveScreenshot: Failed to save screenshot to %s: %s", sPath.c_str(), out.GetError().c_str() );
 		return false;
 	}