Address PR feedback.

This commit is contained in:
Brian Phlipot
2022-12-23 12:34:02 -07:00
committed by teejusb
parent 4a6b1a743c
commit d079940fea
44 changed files with 259 additions and 236 deletions
+10 -1
View File
@@ -30,7 +30,7 @@ bool NoteData::IsComposite() const
{
for( int track = 0; track < GetNumTracks(); ++track )
{
for (const auto& tn : m_TapNotes[track])
for (const std::pair<const int, TapNote>& tn : m_TapNotes[track])
if( tn.second.pn != PLAYER_INVALID )
return true;
}
@@ -1339,6 +1339,15 @@ NoteData::_all_tracks_iterator<ND, iter, TN>::_all_tracks_iterator( const _all_t
m_pNoteData->AddATIToList(this);
}
template<typename ND, typename iter, typename TN>
NoteData::_all_tracks_iterator<ND, iter, TN>::~_all_tracks_iterator()
{
if(m_pNoteData != nullptr)
{
m_pNoteData->RemoveATIFromList(this);
}
}
template<typename ND, typename iter, typename TN>
NoteData::_all_tracks_iterator<ND, iter, TN> &NoteData::_all_tracks_iterator<ND, iter, TN>::operator=( const _all_tracks_iterator &other )
{