actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix PlayMode change message being broadcast multiple times if 2 players joined

Browse Source
This commit is contained in:
Chris Danford
2005-07-25 06:47:43 +00:00
parent 240666b390
commit cdb3b2da17
1 changed files with 33 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/ScreenSelect.cpp
+33 -3
View File
@@ -175,15 +175,45 @@ void ScreenSelect::HandleScreenMessage( const ScreenMessage SM )
{
if( SM == SM_BeginFadingOut ) /* Screen is starting to tween out. */
{
/*
* Don't call GameCommand::Apply once per player on screens that
* have a shared selection. This can cause change messages to be broadcast
* multiple times. Detect whether all players have the same choice, and
* if so, call ApplyToAll instead.
* TODO: Think of a better way to handle this.
*/
int iMastersIndex = this->GetSelectionIndex( GAMESTATE->m_MasterPlayerNumber );
bool bAllPlayersChoseTheSame = true;
FOREACH_HumanPlayer( p )
{
int iIndex = this->GetSelectionIndex(p);
GameCommand &gc = m_aGameCommands[iIndex];
if( this->GetSelectionIndex(p) != iMastersIndex )
{
bAllPlayersChoseTheSame = false;
break;
}
}
if( bAllPlayersChoseTheSame )
{
GameCommand &gc = m_aGameCommands[iMastersIndex];
CString sThisScreen = gc.GetAndClearScreen();
if( m_sNextScreen == "" )
m_sNextScreen = sThisScreen;
gc.Apply( p );
gc.ApplyToAllPlayers();
}
else
{
FOREACH_HumanPlayer( p )
{
int iIndex = this->GetSelectionIndex(p);
GameCommand &gc = m_aGameCommands[iIndex];
CString sThisScreen = gc.GetAndClearScreen();
if( m_sNextScreen == "" )
m_sNextScreen = sThisScreen;
gc.Apply( p );
}
}
SCREENMAN->RefreshCreditsMessages();