cleanup: don't export options from SM_GoToNextScreen

(need to get rid of this AutoScreenMessage thing; causes duplicate variables
to be declared for every file that includes it)

stepmania/src/ScreenOptions.cpp

@@ -503,12 +503,7 @@ void ScreenOptions::HandleScreenMessage( const ScreenMessage SM )
 	{
 		this->BeginFadingOut();
 	}
-	else if( SM == SM_GoToPrevScreen )
+	else if( SM == SM_ExportOptions )
-	{
-//		this->ExportOptions();	// Don't save options if we're going back!
-		this->GoToPrevScreen();
-	}
-	else if( SM == SM_GoToNextScreen )
 	{
 		for( unsigned r=0; r<m_pRows.size(); r++ )		// foreach row
 		{
@@ -517,13 +512,21 @@ void ScreenOptions::HandleScreenMessage( const ScreenMessage SM )
 				vpns.push_back( p );
 			this->ExportOptions( r, vpns );
 		}
+		this->HandleScreenMessage( SM_GoToNextScreen );
+	}
+	else if( SM == SM_GoToNextScreen )
+	{
 		this->GoToNextScreen();
 	}
+	else if( SM == SM_GoToPrevScreen )
+	{
+		this->GoToPrevScreen();
+	}
 	else if( SM == SM_BeginFadingOut )
 	{
 		if(IsTransitioning())
 			return; /* already transitioning */
-		StartTransitioning( SM_GoToNextScreen );
+		StartTransitioning( SM_ExportOptions );
 
 		SCREENMAN->PlayStartSound();
 

stepmania/src/ScreenOptions.h

@@ -12,6 +12,8 @@
 
 class OptionRowHandler;
 
+AutoScreenMessage( SM_ExportOptions )
+
 enum InputMode 
 { 
 	INPUTMODE_INDIVIDUAL, 	// each player controls their own cursor

stepmania/src/ScreenOptionsMaster.cpp

@@ -212,7 +212,7 @@ void ScreenOptionsMaster::RefreshIcons( int r, PlayerNumber pn )
 
 void ScreenOptionsMaster::HandleScreenMessage( const ScreenMessage SM )
 {
-	if( SM == SM_GoToNextScreen )
+	if( SM == SM_ExportOptions )
 	{
 		//
 		// Override ScreenOptions's calling of ExportOptions
@@ -271,7 +271,7 @@ void ScreenOptionsMaster::HandleScreenMessage( const ScreenMessage SM )
 
 		CHECKPOINT;
 		if( !(m_iChangeMask & OPT_RESET_GAME) )
-			this->GoToNextScreen();
+			this->HandleScreenMessage( SM_GoToNextScreen );
 	}
 	else
 		ScreenOptions::HandleScreenMessage( SM );