Remove GotoURL

"Report" button has not been removed from CrashHandlerChild / Crash.mm / DialogDriver_Win32, but functionality has been removed.

src/arch/ArchHooks/ArchHooks.cpp

@@ -51,11 +51,6 @@ bool ArchHooks::AppFocusChanged()
 	return bFocusChanged;
 }
 
-bool ArchHooks::GoToURL( RString sUrl )
-{
-	return false;
-}
-
 ArchHooks *ArchHooks::Create()
 {
 	return new ARCH_HOOKS;

src/arch/ArchHooks/ArchHooks.h

@@ -114,11 +114,6 @@ public:
 	 */
 	bool AppFocusChanged();
 
-	/*
-	 * Open a URL in the default web browser
-	 */
-	virtual bool GoToURL( RString sUrl );
-
 	virtual float GetDisplayAspectRatio() = 0;
 
 	/** @brief Fetch the contents of the system clipboard. */

src/arch/ArchHooks/ArchHooks_MacOSX.h

@@ -10,7 +10,6 @@ public:
 	RString GetArchName() const;
 	void DumpDebugInfo();
 	RString GetPreferredLanguage();
-	bool GoToURL( RString sUrl );
 	float GetDisplayAspectRatio();
 };
 

src/arch/ArchHooks/ArchHooks_MacOSX.mm

@@ -248,16 +248,6 @@ RString ArchHooks::GetPreferredLanguage()
 	return ret;
 }
 
-bool ArchHooks_MacOSX::GoToURL( RString sUrl )
-{
-	CFURLRef url = CFURLCreateWithBytes( kCFAllocatorDefault, (const UInt8*)sUrl.data(),
-						 sUrl.length(), kCFStringEncodingUTF8, nil);
-	OSStatus result = LSOpenCFURLRef( url, nil);
-
-	CFRelease( url );
-	return result == 0;
-}
-
 int64_t ArchHooks::GetSystemTimeInMicroseconds()
 {
 	// http://developer.apple.com/qa/qa2004/qa1398.html

src/arch/ArchHooks/ArchHooks_Unix.cpp

@@ -226,31 +226,6 @@ void ArchHooks_Unix::Init()
 #endif
 }
 
-bool ArchHooks_Unix::GoToURL( RString sUrl )
-{
-	int status;
-	pid_t p = fork();
-	if ( p == -1 )
-	{
-		// Call to fork failed
-		return false;
-	}
-	else if ( p == 0 )
-	{
-		// Child
-		const char * const argv[] = { "xdg-open", sUrl.c_str(), nullptr };
-		execv( "/usr/bin/xdg-open", const_cast<char * const *>( argv ));
-		// If we reach here, the call to execvp failed
-		exit( 1 );
-	}
-	else
-	{
-		// Parent
-		waitpid( p, &status, 0 );
-		return WEXITSTATUS( status ) == 0;
-	}
-}
-
 #ifndef _CS_GNU_LIBC_VERSION
 #define _CS_GNU_LIBC_VERSION 2
 #endif

src/arch/ArchHooks/ArchHooks_Unix.h

@@ -18,8 +18,6 @@ public:
 	void MountInitialFilesystems( const RString &sDirOfExecutable );
 	float GetDisplayAspectRatio() { return 4.0f/3; }
 
-	bool GoToURL( RString sUrl );
-
 	static clockid_t GetClock();
 
 	RString GetClipboard();

src/arch/ArchHooks/ArchHooks_Win32.cpp

@@ -9,7 +9,6 @@
 #include "archutils/win32/DebugInfoHunt.h"
 #include "archutils/win32/ErrorStrings.h"
 #include "archutils/win32/RestartProgram.h"
-#include "archutils/win32/GotoURL.h"
 #include "archutils/Win32/RegistryAccess.h"
 
 #include "VersionHelpers.h"
@@ -171,11 +170,6 @@ void ArchHooks_Win32::SetupConcurrentRenderingThread()
 	SetThreadPriority( GetCurrentThread(), THREAD_PRIORITY_ABOVE_NORMAL );
 }
 
-bool ArchHooks_Win32::GoToURL( RString sUrl )
-{
-	return ::GotoURL( sUrl );
-}
-
 float ArchHooks_Win32::GetDisplayAspectRatio()
 {
 	DEVMODE dm;

src/arch/ArchHooks/ArchHooks_Win32.h

@@ -20,7 +20,6 @@ public:
 	void UnBoostPriority();
 	void SetupConcurrentRenderingThread();
 
-	bool GoToURL( RString sUrl );
 	virtual float GetDisplayAspectRatio();
 	RString GetClipboard();
 };

src/arch/Dialog/DialogDriver_Win32.cpp

@@ -9,7 +9,6 @@
 
 #include "archutils/win32/AppInstance.h"
 #include "archutils/win32/ErrorStrings.h"
-#include "archutils/win32/GotoURL.h"
 #include "archutils/win32/RestartProgram.h"
 #include "archutils/Win32/SpecialDirs.h"
 #if !defined(SMPACKAGE)
@@ -179,7 +178,7 @@ static INT_PTR CALLBACK ErrorWndProc( HWND hWnd, UINT msg, WPARAM wParam, LPARAM
 			}
 			break;
 		case IDC_BUTTON_REPORT:
-			GotoURL( REPORT_BUG_URL );
+			// safe to remove this button?
 			break;
 		case IDC_BUTTON_RESTART:
 			Win32RestartProgram();