From b6cc8f90fca992eecc0bfe92e1a39b5217a20703 Mon Sep 17 00:00:00 2001 From: Martin Natano Date: Wed, 11 May 2022 20:09:03 +0200 Subject: [PATCH] Align defaults with SL recommendations --- src/InputFilter.cpp | 8 ++++++-- src/PrefsManager.cpp | 20 ++++++++++---------- src/ScreenGameplay.cpp | 1 - 3 files changed, 16 insertions(+), 13 deletions(-) diff --git a/src/InputFilter.cpp b/src/InputFilter.cpp index 28f9193af1..ce323a0f8b 100644 --- a/src/InputFilter.cpp +++ b/src/InputFilter.cpp @@ -107,8 +107,12 @@ namespace * * This delay in events is ordinarily not noticable, because we report initial * presses and releases immediately. However, if a real press is ever delayed, - * this won't cause timing problems, because the event timestamp is preserved. */ -static Preference g_fInputDebounceTime( "InputDebounceTime", 0 ); + * this won't cause timing problems, because the event timestamp is preserved. + * + * For pad play, a value of 20ms-50ms seems to result in a better experience. + * For keyboard play, this is often set to 0. + * */ +static Preference g_fInputDebounceTime( "InputDebounceTime", 0.02 ); InputFilter* INPUTFILTER = nullptr; // global and accessible from anywhere in our program diff --git a/src/PrefsManager.cpp b/src/PrefsManager.cpp index 18fcf0a5d4..92042e6dbd 100644 --- a/src/PrefsManager.cpp +++ b/src/PrefsManager.cpp @@ -176,7 +176,7 @@ PrefsManager::PrefsManager() : m_bPAL ( "PAL", false ), m_bDelayedTextureDelete ( "DelayedTextureDelete", false ), m_bDelayedModelDelete ( "DelayedModelDelete", false ), - m_ImageCache ( "ImageCache", IMGCACHE_LOW_RES_PRELOAD ), + m_ImageCache ( "ImageCache", IMGCACHE_LOW_RES_PRELOAD ), m_bFastLoad ( "FastLoad", true ), m_NeverCacheList ( "NeverCacheList", ""), @@ -197,7 +197,7 @@ PrefsManager::PrefsManager() : m_bMercifulBeginner ( "MercifulBeginner", false ), m_bMercifulSuperMeter ( "MercifulSuperMeter", true ), m_bDelayedBack ( "DelayedBack", true ), - m_AllowHoldForOptions("AllowHoldForOptions", true), + m_AllowHoldForOptions ( "AllowHoldForOptions", true ), m_bShowInstructions ( "ShowInstructions", true ), m_bShowCaution ( "ShowCaution", true ), m_bShowNativeLanguage ( "ShowNativeLanguage", true ), @@ -211,10 +211,10 @@ PrefsManager::PrefsManager() : m_iSongsPerPlay ( "SongsPerPlay", 3, ValidateSongsPerPlay ), m_bDelayedCreditsReconcile ( "DelayedCreditsReconcile", false ), m_bComboContinuesBetweenSongs ( "ComboContinuesBetweenSongs", false ), - m_AllowMultipleToasties ("AllowMultipleToasties", true ), - m_MinTNSToHideNotes ("MinTNSToHideNotes", TNS_W3 ), + m_AllowMultipleToasties ( "AllowMultipleToasties", true ), + m_MinTNSToHideNotes ( "MinTNSToHideNotes", TNS_W3 ), m_ShowSongOptions ( "ShowSongOptions", Maybe_NO ), - m_bPercentageScoring ( "PercentageScoring", false ), + m_bPercentageScoring ( "PercentageScoring", true ), // Wow, these preference names are *seriously* long -Colby m_fMinPercentageForMachineSongHighScore ( "MinPercentageForMachineSongHighScore", 0.0001f ), // This is for home, who cares how bad you do? m_fMinPercentageForMachineCourseHighScore ( "MinPercentageForMachineCourseHighScore", 0.0001f ), // don't save course scores with 0 percentage @@ -223,7 +223,7 @@ PrefsManager::PrefsManager() : m_bAutogenGroupCourses ( "AutogenGroupCourses", true ), m_bOnlyPreferredDifficulties ( "OnlyPreferredDifficulties", false ), m_bBreakComboToGetItem ( "BreakComboToGetItem", false ), - m_bLockCourseDifficulties ( "LockCourseDifficulties", true ), + m_bLockCourseDifficulties ( "LockCourseDifficulties", false ), m_ShowDancingCharacters ( "ShowDancingCharacters", SDC_Random ), m_bUseUnlockSystem ( "UseUnlockSystem", false ), m_fGlobalOffsetSeconds ( "GlobalOffsetSeconds", -0.008f ), @@ -272,7 +272,7 @@ PrefsManager::PrefsManager() : m_sDefaultTheme ( "DefaultTheme", "Simply Love" ), m_sLastSeenVideoDriver ( "LastSeenVideoDriver", "" ), m_sVideoRenderers ( "VideoRenderers", "" ), // StepMania.cpp sets these on first run: - m_bSmoothLines ( "SmoothLines", false ), + m_bSmoothLines ( "SmoothLines", true ), m_iSoundWriteAhead ( "SoundWriteAhead", 0 ), m_iSoundDevice ( "SoundDevice", "" ), m_iRageSoundSampleCountClamp ("RageSoundSampleCountClamp", 0), //some sound drivers mask the sample location number, the most popular number for this is 2^27, this causes lockup after ~50 minutes at 44.1khz sample rate @@ -310,7 +310,7 @@ PrefsManager::PrefsManager() : m_bLogCheckpoints ( "LogCheckpoints", false ), m_bShowLoadingWindow ( "ShowLoadingWindow", true ), m_bPseudoLocalize ( "PseudoLocalize", false ), - m_show_theme_errors("ShowThemeErrors", false) + m_show_theme_errors ( "ShowThemeErrors", false ) { Init(); @@ -375,7 +375,7 @@ void PrefsManager::RestoreGamePrefs() gp = iter->second; m_sAnnouncer .Set( gp.m_sAnnouncer ); - m_sTheme .Set( gp.m_sTheme ); + m_sTheme .Set( gp.m_sTheme ); m_sDefaultModifiers .Set( gp.m_sDefaultModifiers ); // give Static.ini a chance to clobber the saved game prefs @@ -467,7 +467,7 @@ void PrefsManager::ReadGamePrefsFromIni( const RString &sIni ) // todo: read more prefs here? -aj ini.GetValue(section_name, "Announcer", gp.m_sAnnouncer); - ini.GetValue(section_name, "Theme", gp.m_sTheme); + ini.GetValue(section_name, "Theme", gp.m_sTheme); ini.GetValue(section_name, "DefaultModifiers", gp.m_sDefaultModifiers); } } diff --git a/src/ScreenGameplay.cpp b/src/ScreenGameplay.cpp index c3c696f95a..b3c6299b83 100644 --- a/src/ScreenGameplay.cpp +++ b/src/ScreenGameplay.cpp @@ -92,7 +92,6 @@ AutoScreenMessage( SM_BattleTrickLevel3 ); static Preference g_bCenter1Player( "Center1Player", false ); static Preference g_bShowLyrics( "ShowLyrics", true ); -static Preference g_fNetStartOffset( "NetworkStartOffset", -3.0 ); static Preference g_bEasterEggs( "EasterEggs", true );