From b5a2f86277cc482d67833be44dc1b93597fab603 Mon Sep 17 00:00:00 2001 From: sukibaby <163092272+sukibaby@users.noreply.github.com> Date: Tue, 29 Apr 2025 22:50:53 -0700 Subject: [PATCH] SaveScreenshot: Use const & in function header Pass sPath by reference to avoid unnecessary copies. --- src/RageDisplay.cpp | 2 +- src/RageDisplay.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/RageDisplay.cpp b/src/RageDisplay.cpp index 52208ad4ff..1c55f28079 100644 --- a/src/RageDisplay.cpp +++ b/src/RageDisplay.cpp @@ -767,7 +767,7 @@ void RageDisplay::UpdateCentering() (float) p.m_iTranslateX, (float) p.m_iTranslateY, (float) p.m_iAddWidth, (float) p.m_iAddHeight ); } -bool RageDisplay::SaveScreenshot( RString sPath, GraphicsFileFormat format ) +bool RageDisplay::SaveScreenshot( const RString &sPath, GraphicsFileFormat format ) { RageTimer timer; RageSurface *surface = this->CreateScreenshot(); diff --git a/src/RageDisplay.h b/src/RageDisplay.h index b6738ed252..d87afdc820 100644 --- a/src/RageDisplay.h +++ b/src/RageDisplay.h @@ -360,7 +360,7 @@ public: SAVE_LOSSY_LOW_QUAL, // jpg SAVE_LOSSY_HIGH_QUAL // jpg }; - bool SaveScreenshot( RString sPath, GraphicsFileFormat format ); + bool SaveScreenshot( const RString &sPath, GraphicsFileFormat format ); virtual RString GetTextureDiagnostics( uintptr_t /* id */ ) const { return RString(); } virtual RageSurface* CreateScreenshot() = 0; // allocates a surface. Caller must delete it.