From e67324c5af1ea75af5d617556ba84697c2ec08a4 Mon Sep 17 00:00:00 2001 From: Jason Felds Date: Tue, 12 Jul 2011 14:51:52 -0400 Subject: [PATCH 1/3] Add StepsUseChartName metric. This is in ScreenOptionsMaster. To the C++ guys: please don't yell at the goto. --- Docs/Changelog_sm5.txt | 7 +++++++ Themes/_fallback/metrics.ini | 1 + src/OptionRowHandler.cpp | 10 ++++++++++ 3 files changed, 18 insertions(+) diff --git a/Docs/Changelog_sm5.txt b/Docs/Changelog_sm5.txt index 73015cca56..93af05977d 100644 --- a/Docs/Changelog_sm5.txt +++ b/Docs/Changelog_sm5.txt @@ -8,6 +8,13 @@ ________________________________________________________________________________ StepMania 5.0 ????????? | 20110??? -------------------------------------------------------------------------------- +2011/07/12 +---------- +* [OptionRowHandler] Add a new metric to ScreenOptionsMaster: + StepsUseChartName. Use this if you want your charts to have a unique name + in the options menu. If there is no #CHARTNAME or it is "Blank", it reverts + to the original behavior. This metric is false by default. [Wolfman2000] + 2011/07/09 ---------- * [NotesTheUsual] Update the #COMBOS tag to allow for a Miss Combo attribute. diff --git a/Themes/_fallback/metrics.ini b/Themes/_fallback/metrics.ini index ad995db105..4d3f9d6514 100644 --- a/Themes/_fallback/metrics.ini +++ b/Themes/_fallback/metrics.ini @@ -2091,6 +2091,7 @@ OptionRowExitMetricsGroup="OptionRowExit" Fallback="ScreenOptions" Class="ScreenOptionsMaster" NoteSkinSortOrder="" +StepsUseChartName=false # ExitItem is an exit row with the "Exit" text as a menu item; ExitTitle # uses the menu title. diff --git a/src/OptionRowHandler.cpp b/src/OptionRowHandler.cpp index 00125fa6b1..02d05c5aa1 100644 --- a/src/OptionRowHandler.cpp +++ b/src/OptionRowHandler.cpp @@ -28,6 +28,7 @@ #define ENTRY_MODE(s,i) THEME->GetMetric ("ScreenOptionsMaster",ssprintf("%s,%i",(s).c_str(),(i+1))) #define ENTRY_DEFAULT(s) THEME->GetMetric ("ScreenOptionsMaster",(s) + "Default") #define NOTE_SKIN_SORT_ORDER THEME->GetMetric ("ScreenOptionsMaster","NoteSkinSortOrder") +#define STEPS_USE_CHART_NAME THEME->GetMetricB("ScreenOptionsMaster","StepsUseChartName") static const char *SelectTypeNames[] = { "SelectOne", @@ -449,6 +450,14 @@ class OptionRowHandlerListSteps : public OptionRowHandlerList Steps* pSteps = vpSteps[i]; RString s; + if (STEPS_USE_CHART_NAME) + { + s = pSteps->GetChartName(); + if (!(s == "" || s == "blank" || s == "Blank")) + { + goto nameGotten; + } + } if( pSteps->GetDifficulty() == Difficulty_Edit ) { s = pSteps->GetDescription(); @@ -460,6 +469,7 @@ class OptionRowHandlerListSteps : public OptionRowHandlerList else s = CustomDifficultyToLocalizedString( GetCustomDifficulty( pSteps->m_StepsType, pSteps->GetDifficulty(), CourseType_Invalid ) ); } + nameGotten: s += ssprintf( " %d", pSteps->GetMeter() ); m_Def.m_vsChoices.push_back( s ); GameCommand mc; From 5bec1e3e761ceeae677c28b034c8550f56dffca1 Mon Sep 17 00:00:00 2001 From: Jason Felds Date: Tue, 12 Jul 2011 15:01:50 -0400 Subject: [PATCH 2/3] Add comment. This really seems like something that should be in lua. --- src/OptionRowHandler.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/OptionRowHandler.cpp b/src/OptionRowHandler.cpp index 02d05c5aa1..594af3f5ec 100644 --- a/src/OptionRowHandler.cpp +++ b/src/OptionRowHandler.cpp @@ -453,6 +453,7 @@ class OptionRowHandlerListSteps : public OptionRowHandlerList if (STEPS_USE_CHART_NAME) { s = pSteps->GetChartName(); + // TODO: find a way to make this use lua. if (!(s == "" || s == "blank" || s == "Blank")) { goto nameGotten; From ba609541e8d7b468d50d5cc1e28c93c318e1fecd Mon Sep 17 00:00:00 2001 From: Jason Felds Date: Tue, 12 Jul 2011 15:03:44 -0400 Subject: [PATCH 3/3] Allow edits to be missed. --- Data/AI.ini | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Data/AI.ini b/Data/AI.ini index 24185ed635..7ca232dfac 100644 --- a/Data/AI.ini +++ b/Data/AI.ini @@ -39,7 +39,7 @@ WeightW2=30 WeightW1=50 [Skill5] -WeightMiss= +WeightMiss=8 WeightW5=1 WeightW4=1 WeightW3=5 @@ -47,9 +47,9 @@ WeightW2=30 WeightW1=55 [Skill6] -WeightMiss=0 -WeightW5=0 -WeightW4=0 +WeightMiss=8 +WeightW5=1 +WeightW4=1 WeightW3=5 WeightW2=30 -WeightW1=70 \ No newline at end of file +WeightW1=55