diff --git a/Themes/_fallback/metrics.ini b/Themes/_fallback/metrics.ini index 25481ecac2..df8a62cc12 100644 --- a/Themes/_fallback/metrics.ini +++ b/Themes/_fallback/metrics.ini @@ -49,10 +49,6 @@ InitialScreen="ScreenInit" OverlayScreens="ScreenSystemLayer,ScreenSyncOverlay,ScreenStatsOverlay,ScreenDebugOverlay" # Legacy metric: Percentage Scoring shows this many decimals ( 00.00% ). PercentScoreDecimalPlaces=2 -# What should certain player-only elements do. we usually just color them to -# show who's stuff is who's. you'd best leave this alone too. -ColorP1Command=diffuse,PlayerColor(PLAYER_1) -ColorP2Command=diffuse,PlayerColor(PLAYER_2) # 02 # [LightsManager] diff --git a/src/CommonMetrics.cpp b/src/CommonMetrics.cpp index 9a235c8e95..f7764b71ce 100644 --- a/src/CommonMetrics.cpp +++ b/src/CommonMetrics.cpp @@ -8,12 +8,8 @@ #include "ProductInfo.h" #include "LuaManager.h" - -static RString PLAYER_COLOR_NAME( size_t p ) { return ssprintf("ColorP%dCommand",int(p+1)); } - ThemeMetric CommonMetrics::FIRST_ATTRACT_SCREEN ("Common","FirstAttractScreen"); ThemeMetric CommonMetrics::DEFAULT_MODIFIERS ("Common","DefaultModifiers" ); -ThemeMetric1D CommonMetrics::PLAYER_COLOR ("Common",PLAYER_COLOR_NAME,NUM_PLAYERS); LocalizedString CommonMetrics::WINDOW_TITLE ("Common","WindowTitle"); ThemeMetric CommonMetrics::MAX_COURSE_ENTRIES_BEFORE_VARIOUS("Common","MaxCourseEntriesBeforeShowVarious"); ThemeMetric CommonMetrics::TICK_EARLY_SECONDS ("ScreenGameplay","TickEarlySeconds"); diff --git a/src/CommonMetrics.h b/src/CommonMetrics.h index 99b247700e..70ef892751 100644 --- a/src/CommonMetrics.h +++ b/src/CommonMetrics.h @@ -9,10 +9,7 @@ #include "GameConstantsAndTypes.h" #include "LocalizedString.h" - -// // Types -// class ThemeMetricDifficultiesToShow : public ThemeMetric { public: @@ -45,22 +42,19 @@ private: }; -// // Metrics -// namespace CommonMetrics { extern ThemeMetric FIRST_ATTRACT_SCREEN; extern ThemeMetric DEFAULT_MODIFIERS; - extern ThemeMetric1D PLAYER_COLOR; // TODO: Remove this and do all coloring in Lua - extern LocalizedString WINDOW_TITLE; + extern LocalizedString WINDOW_TITLE; extern ThemeMetric MAX_COURSE_ENTRIES_BEFORE_VARIOUS; - extern ThemeMetric TICK_EARLY_SECONDS; + extern ThemeMetric TICK_EARLY_SECONDS; extern ThemeMetric DEFAULT_NOTESKIN_NAME; - extern ThemeMetricDifficultiesToShow DIFFICULTIES_TO_SHOW; + extern ThemeMetricDifficultiesToShow DIFFICULTIES_TO_SHOW; extern ThemeMetricCourseDifficultiesToShow COURSE_DIFFICULTIES_TO_SHOW; extern ThemeMetricStepsTypesToShow STEPS_TYPES_TO_SHOW; - extern ThemeMetric AUTO_SET_STYLE; + extern ThemeMetric AUTO_SET_STYLE; extern ThemeMetric PERCENT_SCORE_DECIMAL_PLACES; RString LocalizeOptionItem( const RString &s, bool bOptional ); diff --git a/src/ScoreDisplayOni.cpp b/src/ScoreDisplayOni.cpp index 1a0f0bc096..6d2d054ca0 100644 --- a/src/ScoreDisplayOni.cpp +++ b/src/ScoreDisplayOni.cpp @@ -27,11 +27,6 @@ ScoreDisplayOni::ScoreDisplayOni() void ScoreDisplayOni::Init( const PlayerState* pPlayerState, const PlayerStageStats* pPlayerStageStats ) { ScoreDisplay::Init( pPlayerState, pPlayerStageStats ); - - // TODO: Remove use of PlayerNumber. - PlayerNumber pn = pPlayerState->m_PlayerNumber; - - m_text.RunCommands( CommonMetrics::PLAYER_COLOR.GetValue(pn) ); } diff --git a/src/ScreenSelectMusic.cpp b/src/ScreenSelectMusic.cpp index 2a4b4b4b15..631655a6d4 100644 --- a/src/ScreenSelectMusic.cpp +++ b/src/ScreenSelectMusic.cpp @@ -192,8 +192,6 @@ void ScreenSelectMusic::Init() m_textHighScore[p].SetName( ssprintf("ScoreP%d",p+1) ); m_textHighScore[p].LoadFromFont( THEME->GetPathF(m_sName,"score") ); - //m_textHighScore[p].SetShadowLength( 0 ); - //m_textHighScore[p].RunCommands( CommonMetrics::PLAYER_COLOR.GetValue(p) ); LOAD_ALL_COMMANDS_AND_SET_XY( m_textHighScore[p] ); this->AddChild( &m_textHighScore[p] ); }