Split Update into Update and UpdateInternal so that every class doesn't need to early abort in Update when hibernating

stepmania/src/Actor.cpp

@@ -486,9 +486,6 @@ void Actor::Update( float fDeltaTime )
 //	LOG->Trace( "Actor::Update( %f )", fDeltaTime );
 	ASSERT_M( fDeltaTime >= 0, ssprintf("%f",fDeltaTime) );
 
-	if( m_bFirstUpdate )
-		m_bFirstUpdate = false;
-
 	if( m_fHibernateSecondsLeft > 0 )
 	{
 		m_fHibernateSecondsLeft -= fDeltaTime;
@@ -500,6 +497,14 @@ void Actor::Update( float fDeltaTime )
 		m_fHibernateSecondsLeft = 0;
 	}
 
+	this->UpdateInternal( fDeltaTime );
+}
+
+void Actor::UpdateInternal( float fDeltaTime )
+{
+	if( m_bFirstUpdate )
+		m_bFirstUpdate = false;
+
 	switch( m_EffectClock )
 	{
 	case CLOCK_TIMER:
@@ -1052,6 +1057,13 @@ bool Actor::HasCommand( const CString &sCmdName )
 	return it != m_mapNameToCommands.end();
 }
 
+const apActorCommands& Actor::GetCommand( const CString &sCommandName ) const
+{
+	map<CString, apActorCommands>::const_iterator it = m_mapNameToCommands.find( sCommandName );
+	ASSERT( it != m_mapNameToCommands.end() );
+	return it->second;
+}
+
 void Actor::PlayCommand( const CString &sCommandName )
 {
 	PlayCommand2( sCommandName, NULL );

stepmania/src/Actor.h

@@ -87,8 +87,11 @@ public:
 	virtual void DrawPrimitives() {};	// Derivitives should override
 	virtual void EndDraw();				// pops transform from world matrix stack
 	
+	// TODO: make Update non virtual and change all classes to override UpdateInternal 
+	// instead.
 	bool IsFirstUpdate() const;
-	virtual void Update( float fDeltaTime );
+	virtual void Update( float fDeltaTime );		// this can short circuit UpdateInternal
+	virtual void UpdateInternal( float fDeltaTime );	// override this
 	void UpdateTweening( float fDeltaTime );
 	void CopyTweening( const Actor &from );
 
@@ -333,6 +336,7 @@ public:
 	virtual void PushSelf( lua_State *L );
 	void AddCommand( const CString &sCmdName, apActorCommands apac );
 	bool HasCommand( const CString &sCmdName );
+	const apActorCommands& GetCommand( const CString &sCommandName ) const;
 	virtual void PlayCommand( const CString &sCommandName );
 	virtual void PlayCommand2( const CString &sCommandName, Actor *pParent );
 	virtual void RunCommands( const LuaReference& cmds );

stepmania/src/ActorFrame.cpp

@@ -216,16 +216,13 @@ void ActorFrame::RunCommandsOnLeaves( const LuaReference& cmds )
 		m_SubActors[i]->RunCommandsOnLeaves( cmds );
 }
 
-void ActorFrame::Update( float fDeltaTime )
+void ActorFrame::UpdateInternal( float fDeltaTime )
 {
 //	LOG->Trace( "ActorFrame::Update( %f )", fDeltaTime );
 
 	fDeltaTime *= m_fUpdateRate;
 
-	Actor::Update( fDeltaTime );
+	Actor::UpdateInternal( fDeltaTime );
-
-	if( m_fHibernateSecondsLeft > 0 )
-		return;
 
 	// update all sub-Actors
 	for( vector<Actor*>::iterator it=m_SubActors.begin(); it!=m_SubActors.end(); it++ )

stepmania/src/ActorFrame.h

@@ -71,7 +71,7 @@ public:
 	virtual void RunCommandsOnChildren( const apActorCommands& cmds ) { RunCommandsOnChildren( *cmds ); }	// convenience
 	virtual void RunCommandsOnLeaves( const LuaReference& cmds ); /* but not on self */
 
-	virtual void Update( float fDeltaTime );
+	virtual void UpdateInternal( float fDeltaTime );
 	virtual void DrawPrimitives();
 
 	// propagated commands

stepmania/src/ActorScroller.cpp

@@ -153,12 +153,9 @@ void ActorScroller::LoadFromNode( const CString &sDir, const XNode *pNode )
 	pNode->GetAttrValue( "QuantizePixels", m_fQuantizePixels );
 }
 
-void ActorScroller::Update( float fDeltaTime )
+void ActorScroller::UpdateInternal( float fDeltaTime )
 {
-	ActorFrame::Update( fDeltaTime );
+	ActorFrame::UpdateInternal( fDeltaTime );
-
-	if( m_fHibernateSecondsLeft > 0 )
-		return;	// early abort
 
 	/* If we have no children, the code below will busy loop. */
 	if( !m_SubActors.size() )

stepmania/src/ActorScroller.h

@@ -42,7 +42,7 @@ public:
 		const CString &sTransformFunction,
 		bool bUseMask );
 
-	virtual void Update( float fDelta );
+	virtual void UpdateInternal( float fDelta );
 	virtual void DrawPrimitives();	// DOES draw
 
 	void LoadFromNode( const CString &sDir, const XNode *pNode );

stepmania/src/BGAnimationLayer.cpp

@@ -556,12 +556,9 @@ void BGAnimationLayer::LoadFromNode( const CString& sDir, const XNode* pNode )
 	}
 }
 
-void BGAnimationLayer::Update( float fDeltaTime )
+void BGAnimationLayer::UpdateInternal( float fDeltaTime )
 {
-	if( m_fHibernateSecondsLeft > 0 )
+	ActorFrame::UpdateInternal( fDeltaTime );
-		return;
-
-	ActorFrame::Update( fDeltaTime );
 
 	fDeltaTime *= m_fUpdateRate;
 

stepmania/src/BGAnimationLayer.h

@@ -20,7 +20,7 @@ public:
 	void LoadFromAniLayerFile( const CString& sPath );
 	void LoadFromNode( const CString& sDir, const XNode* pNode );
 
-	void Update( float fDeltaTime );
+	void UpdateInternal( float fDeltaTime );
 	void DrawPrimitives();
 	bool EarlyAbortDraw();
 

stepmania/src/ThemeManager.cpp

@@ -629,9 +629,7 @@ bool ThemeManager::GetMetricRaw( const CString &sClassName, const CString &sValu
 
 	CString sFallback;
 
-	for( deque<Theme>::const_iterator iter = g_vThemes.begin();
+	FOREACHD_CONST( Theme, g_vThemes, iter )
-		iter != g_vThemes.end();
-		iter++ )
 	{
 		if( iter->iniMetrics->GetValue(sClassName,sValueName,ret) )
 			return true;

stepmania/src/Transition.cpp

@@ -65,7 +65,7 @@ void Transition::Load( CString sBGAniDir )
 }
 
 
-void Transition::Update( float fDeltaTime )
+void Transition::UpdateInternal( float fDeltaTime )
 {
 	if( m_State != transitioning )
 		return;
@@ -83,7 +83,7 @@ void Transition::Update( float fDeltaTime )
 		SCREENMAN->SendMessageToTopScreen( m_MessageToSendWhenDone );
 	}
 
-	ActorFrame::Update( fDeltaTime );
+	ActorFrame::UpdateInternal( fDeltaTime );
 }
 
 void Transition::Reset()

stepmania/src/Transition.h

@@ -16,7 +16,7 @@ public:
 
 	void Load( CString sBGAniDir );
 
-	virtual void Update( float fDeltaTime );
+	virtual void UpdateInternal( float fDeltaTime );
 
 	virtual void StartTransitioning( ScreenMessage send_when_done = SM_None );
 	virtual bool EarlyAbortDraw();