actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix thread safety issue

Browse Source
This commit is contained in:
Glenn Maynard
2004-12-21 10:35:11 +00:00
parent 2f8deb615f
commit 95c4741945
1 changed files with 10 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/RageFileDriverDirectHelpers.cpp
+9 -21
View File
@@ -277,26 +277,17 @@ void DirectFilenameDB::PopulateFileSet( FileSet &fs, const CString &path )
} while( FindNextFile( hFind, &fd ) ); } while( FindNextFile( hFind, &fd ) );
FindClose(hFind); FindClose(hFind);
#else #else
int OldDir = DoOpen(".", O_RDONLY); /* Ugly: POSIX threads are not guaranteed to have per-thread cwds, and only
if( OldDir == -1 ) * a few systems have openat() or equivalent; one or the other is needed
RageException::Throw( "Couldn't open(.): %s", strerror(errno) ); * to do efficient, thread-safe directory traversal. Instead, we have to
* use absolute paths, which forces the system to re-parse the directory
* for each file. This isn't a major issue, since most large directory
* scans are be I/O (disk-seek)-bound. */
if( chdir(root+sPath) == -1 ) DIR *d = opendir(root+sPath);
{
/* Only log once per dir. */
if( LOG && errno != ENOENT )
LOG->MapLog("chdir " + root+"/"+sPath, "Couldn't chdir(%s%s): %s", root.c_str(), sPath.c_str(), strerror(errno) );
close( OldDir );
return;
}
DIR *d = opendir(".");
if( d == NULL ) if( d == NULL )
{ {
LOG->MapLog("opendir " + root+"/"+sPath, "Couldn't opendir(%s%s): %s", root.c_str(), sPath.c_str(), strerror(errno) ); LOG->MapLog("opendir " + root+sPath, "Couldn't opendir(%s%s): %s", root.c_str(), sPath.c_str(), strerror(errno) );
if( fchdir( OldDir ) == -1 )
RageException::Throw( "Couldn't fchdir(): %s", strerror(errno) );
close( OldDir );
return; return;
} }
@@ -309,7 +300,7 @@ void DirectFilenameDB::PopulateFileSet( FileSet &fs, const CString &path )
f.SetName( ent->d_name ); f.SetName( ent->d_name );
struct stat st; struct stat st;
if( DoStat(ent->d_name, &st) == -1 ) if( DoStat(root+sPath + "/" + ent->d_name, &st) == -1 )
{ {
/* If it's a broken symlink, ignore it. Otherwise, warn. */ /* If it's a broken symlink, ignore it. Otherwise, warn. */
if( lstat(ent->d_name, &st) == 0 ) if( lstat(ent->d_name, &st) == 0 )
@@ -330,9 +321,6 @@ void DirectFilenameDB::PopulateFileSet( FileSet &fs, const CString &path )
} }
closedir(d); closedir(d);
if( fchdir( OldDir ) == -1 )
RageException::Throw( "Couldn't fchdir(): %s", strerror(errno) );
close( OldDir );
#endif #endif
} }