actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

preempt possible problems with message handling

Browse Source 
(don't think this is related to my stage screen crash, which
isn't happening in debug; I might just need to rebuild release)
This commit is contained in:
Glenn Maynard
2003-03-15 07:21:09 +00:00
parent 649ad21e43
commit 8d16f52345
1 changed files with 29 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/Screen.cpp
+29 -14
View File
@@ -45,21 +45,36 @@ void Screen::Update( float fDeltaTime )
// update the times of queued ScreenMessages and send if timer has expired // update the times of queued ScreenMessages and send if timer has expired
// The order you remove messages in must be very careful! Sending a message can // The order you remove messages in must be very careful! Sending a message can
// potentially clear all m_QueuedMessages, and set a new state! // potentially clear all m_QueuedMessages, and set a new state!
for( unsigned i=0; i<m_QueuedMessages.size(); i++ ) /* Also, it might call ClearMessageQueue() to clear a single message type.
* This might clear previous messages on the queue. So, first apply time to
* everything. */
unsigned i;
for( i=0; i<m_QueuedMessages.size(); i++ )
m_QueuedMessages[i].fDelayRemaining -= fDeltaTime;
/* Now dispatch messages. If the number of messages on the queue changes
* within HandleScreenMessage, someone cleared messages on the queue. This
* means we have no idea where 'i' is, so start over. Since we applied time
* already, this won't cause messages to be mistimed. */
for( i=0; i<m_QueuedMessages.size(); i++ )
{ {
/* Er, wait. Shouldn't we subtract first? This will make messages if( m_QueuedMessages[i].fDelayRemaining > 0.0f )
* get delayed an extra frame. -glenn */ continue; /* not yet */
if( m_QueuedMessages[i].fDelayRemaining <= 0.0f ) // send this sucker!
{ /* Remove the message from the list. */
this->HandleScreenMessage( m_QueuedMessages[i].SM ); const ScreenMessage SM = m_QueuedMessages[i].SM;
if(i < m_QueuedMessages.size()) m_QueuedMessages.erase(m_QueuedMessages.begin()+i);
m_QueuedMessages.erase(m_QueuedMessages.begin()+i); i--;
i--;
} unsigned size = m_QueuedMessages.size();
else
{ // send this sucker!
m_QueuedMessages[i].fDelayRemaining -= fDeltaTime; this->HandleScreenMessage( SM );
}
/* If the size changed, start over. */
if(size != m_QueuedMessages.size())
i = 0;
} }
} }