actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

pos_map_backlog_frames optimization

Browse Source 
The value was determined by profiling the `Cleanup` function as well as monitoring how frequent "Audio frame out of range" errors occurred. This provides an ideal balance of low latency and prevention of out-of-range errors.
This commit is contained in:
sukibaby
2024-09-30 22:24:32 -07:00
committed by teejusb
parent 7b2f0338b8
commit 8d125f3951
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/RageSoundPosMap.cpp
+7 -7
View File
@@ -9,12 +9,12 @@
#include <cstdint> #include <cstdint>
#include <list> #include <list>
// The number of frames we should keep pos_map data for. // NOTE(sukibaby): The number of frames we should keep pos_map data for.
// This comes out to about ~800kb in audio frames, assuming 44.1khz. // File bitrate, metadata, etc will factor in here. 80k is a safe value
// File bitrate, metadata, etc will factor in here. If the queue is // to provide a good balance of stability and low latency. It is stable
// TOO big it will make things slow, but 200k frames is no problem. // up to 200k, but increased latency is the main reason not to increase
// Making the queue larger than 200k hasn't been tested extensively. // this to a very large number.
const int pos_map_backlog_frames = 200000; static int pos_map_backlog_frames = 80000;
struct pos_map_t struct pos_map_t
{ {
@@ -160,7 +160,7 @@ std::int64_t pos_map_queue::Search( std::int64_t iSourceFrame ) const
if( last.PeekDeltaTime() >= 1.0f ) if( last.PeekDeltaTime() >= 1.0f )
{ {
last.Touch(); last.Touch();
LOG->Trace("Audio frame was out of range of the data sent - possible buffer underflow? This is not always an error, however if you see it frequently there could be sound buffer problems."); LOG->Trace("Audio frame (%lld) was out of range of the data sent - possible buffer underflow? This is not always an error, however if you see it frequently there could be sound buffer problems.", iSourceFrame);
} }
return iClosestPosition; return iClosestPosition;